-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Feat/optimize span svg layout #34185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/optimize span svg layout #34185
Conversation
I agree, this seems to be too prone to false-positives. I still think the best course of actions is to make Vue not output the wrapper in first place: |
The screenshots are not from Vue ...... |
yes, screenshots from gitea/templates/explore/repo_list.tmpl Line 47 in 946fb78
There is a lot of legacy code in the system, such as The goal of this PR is to make the SVG and the subsequent text vertically centered in all such scenarios across the entire system. |
See #34185 (comment), it won't work in all scenarios, instead, it introduces more different cases. The root problem is that you can't assume the parent has "flex" layout. |
946fb78
to
2beacc5
Compare
I did a global search, and it turns out the situation is much more complicated than I thought. I believe there might not be a universal solution. It seems that we really have no other choice but to address each issue as it arises. |
* giteaofficial/main: (27 commits) fix github migration error when using multiple tokens (go-gitea#34144) Add package version api endpoints (go-gitea#34173) Fix incorrect file links (go-gitea#34189) Add cache for common package queries (go-gitea#22491) Allow admins and org owners to change org member public status (go-gitea#28294) Fix span svg layout (go-gitea#34185) fix webhook url (go-gitea#34186) Optimize overflow-menu (go-gitea#34183) Move and rename UpdateRepository (go-gitea#34136) Update milestones.tmpl (go-gitea#34184) [skip ci] Updated translations via Crowdin Refactor Git Attribute & performance optimization (go-gitea#34154) [skip ci] Updated translations via Crowdin fix(go-gitea#33711): cross-publish docker images to ghcr.io (go-gitea#34148) refactor organization menu (go-gitea#33928) feat: Add sorting by exclusive labels (issue priority) (go-gitea#33206) Fix vertical centering of file tree icons and use entryIcon for submodules/symlinks (go-gitea#34137) bugfix check for alternate ssh host certificate location (go-gitea#34146) Cache GPG keys, emails and users when list commits (go-gitea#34086) Set MERMAID_MAX_SOURCE_CHARACTERS to 50000 (go-gitea#34152) ...
before:

after:
