[macOS] Add FLETexture and FLETextureRegistrar. #263
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge from google/flutter-desktop-embedding
Merge from google/flutter-desktop-embedding@master
Merge from google/flutter-desktop-embedding@master
- Add a missing nullability specifier. - Use simplified nullability annotations when possible. - clang-format using project style file. - Add braces to conditionals to match project style. - Add new header to umbrella header.
Merge from google/master
Merge from google/master
Merge pull request from google/master
Closed
|
The macOS code has already been migrated to flutter/engine, and the copy here will be removed once a prebuilt framework is available to transition clients to (per the plan outlined in my recent email to the mailing list), hopefully early next week. Given that, the copy here is frozen, and you'll need to do this as a PR in flutter/engine instead. It should be straightforward to move over, since the code there hasn't changed other than what was done in the migration (e.g., eliminating duplication with existing iOS code). |
|
This is good news, I'll try to resubmit the PR to flutter/engine. :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I compiled this patch using Flutter Channel dev and may need to wait for the built-in Texture support in the FlutterEmbedder.framework stable version to review and merge.