Merge from google/flutter-desktop-embedding@master #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move most C++ library code to common/ and include/ This is a preperatory change for Windows using all of this code. Since it will be shared between multiple platforms, it should live in a shared location. Because the GN build flattens the headers in the generated out/include/, some files have #if/#else branches for #includes. Once there is a final decision on whether to use GN, this can be re-evaluated. * Update header guards for new paths
Disable Xcode's default of automatically managing signing for the example application, as this can cause issues for people who have a developer team configured in Xcode. Should address issue #178
Enables the GLFW raw key event handler for Windows.
Merges the GLFW-based embedding implementations for Windows and Linux into a single shared implementation. At this point the implementations are largely identical, and having two copies is increasingly a maintenance burden. Originally they were separate since they were intended to be throw-away, and their development proceeded at different speeds. Now that they have reached parity, and there's a possibility that the GLFW implementation will be longer-lived than initially expected, having one copy that's testable on several platforms should simplify development.
Fixes #170 The default symbol resolver that is used when no specific resolver is given doesn't resolve according to OpenGL features available in the GLFW context. This causes errors for some users.
Makes explicit what style guides and conventions the project follows, so that contributors can see them in advance rather than discovering them through the review process.
The Flutter engine renamed the flag that controls the "Debug" banner as part of the Dart 2 transition (Engine PR 6977). Update the example apps to pass the new flag in release mode.
Builds Linux via Make and GN, and builds macOS.
Currently building is broken when there are spaces in the path containing the local checkout of the repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.