Merge from google/master #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses #192.
Adds a tool to run anything from tools/dart_tools/bin, rather than needing a custom wrapper for each tool. Changes the update_flutter_engine shell script to match the existing batch script behavior of automatically providing --flutter_root
* Dart analysis-related fixes - Fixes the include path for the example app's analysis file, which broke during the repository restructure. - Removes analysis options that are obsolete in recent Dart versions. - Fix some new analysis issues (mostly constructor ordering).
update_flutter_engine was broken by an incorrect change to try to fix an analyzer warning that didn't end up getting turned on; the default value is false, not null, for the help flag, so the test always passed.
Adds support for building the Windows embedding library using GN. Rewrites the batch scripts used by the Windows build as Dart scripts, so they can be used from GN. Part of #114
The header guard for key_event_handler.h didn't actually work due to a typo.
* Add checkout of jsoncpp back to the VS build script * Make fetch_jsoncpp handle the case where the source is already present
Eliminates Plugin as the primary interface point, and instead moves to a MethodChannel-based model. This eliminates the need for void* types in the interfaces, allowing a move to full type safety (via templates) for all the classes related to channels. Additionally, the plugin creation and registration system now matches the Flutter structure on iOS and Android, using static registration of a plugin class with a PluginRegistrar. The desktop registrar currently has minimal functionality, but it can be extended over time. This is a breaking change for any Plugin implementation, as well as application-level code that was calling AddPlugin. This essentially completes issue #102 for Linux and Windows.
Changes FLEPlugin to be a subset of iOS's FlutterPlugin's API, including changing the plugin creation and registration system. Plugins now create and manage their own channels, instead of relying on FLEViewController for high-level message APIs. This is a breaking change for any FLEPlugin implementation, as well as application-level code that was calling addPlugin:. This essentially completes issue #102 for macOS.
Adds export macros, and annotations for all symbols that should be public. Switches the default for shared library builds on Linux to visibility=hidden so that missing annotations will be caught on both platforms, rather than just Windows. Fixes issue #208
Adds more parity with mobile Flutter plugin APIs. Fixes #173
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.