This repository was archived by the owner on Aug 18, 2020. It is now read-only.
Make develop great again #3462
Merged
Make develop great again #3462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also placate hlint, stylish-haskell, stack2nix
…'. (Exit code: 126)
[DEVOPS-1005] Fix Argument list too long `cc' failed in phase `Linker…
…aph-nixos make compatible with nixos
make stylish-haskell and hlint available inside nix-shell
[CBR-396] Acid-state strict all the way down
This PR makes a number of changes: * Rename the old `Cardano.Wallet.API.Internal.Handlers` module to `Cardano.Wallet.API.Internal.LegacyHandlers`, and introduce a new `Cardano.Wallet.API.Internal.Handlers` module. * Add new field to the kernel DB: the updates downloaded by the launcher, along with the necessary functions to work with this new data. * A new API endpoint for checking for updates * `nextUpdate`, `applyUpdate`, `postponeUpdate` and `resetWalletState` entries in the `PassiveWalletLayer`, along with implementations for the kernel for all of these except for `resetWalletState` (CBR-393) * An implementation of the new check-for-update endpoint also for the legacy implementation. * New functions in the `NodeStateAdaptor` that can be used to wait for an update notification from the launcher and one to trigger a shutdown. (This required extending the internal environment used in `WithNodeState` with a logger function.) This means that except for the reset internal wallet state, the internal endpoints are now implemented. However, this does _NOT_ yet include a plugin that lists for updates and notifies the wallet layer when they come available. This should be done as part of CBR-377.
This was introduced separately as a change on top of the previous develop and therefore, used the structured logging right away and didn't get affected when removing the structured logging PR. The logging is still needed (for the triggerShutdown) function, but the old onw so I've adapted the code, reverting the changes and providing WithLogger instance for the 'WithNodeState m' Monad
…l-API [CBR-250] Support for updates
also cache cabal2nix on hydra
CBR-97 (structured logging) has introduced regressions not detected
by the CI nor testing. The whole PR has been reverted, introducing
possible inconsistency between your local 'develop' and this upstream.
Let's call `develop` the upstream `develop` branch, and `develop-local`
your local `develop` banch.
From here, the best way to go is to:
- Rebase your branches onto this new develop. We are basically telling
git where is the beginning of the branch (`develop-local`) and on
top of what references it should put the branch (`--onto develop`):
git checkout whatever-feature-branch
git rebase --preserve-merges develop-local --onto develop
- Then, reset your local develop to this very commit (or above):
git checkout develop
git reset --hard <commit-hash>
Good Luck!
|
When merging this, make sure to select the right merge option and do a fast forward merge (without merge commit) |
The new implementation is _significantly_ simpler than the one in the legacy wallet. In particular, we do not bother to run coin selection. Instead, we simply 1. Check if there is a UTxO available to the redemption address in the node's UTxO There can be at most 1; if 0, already redeemed. 2. Construct a transaction containing a single input and a single output (to a freshly generated address), for the full amount of the voucher. I've verified this approach with a bunch of people and tried to compare it to the redemption transactions that actually currently exist on the blockchain, and it seems this is indeed the right approach.
[CBR-349] Implement redemption
[CBR-371] wallet-new: add tests for Servant's listAddresses endpoint
[CHW] Implement basic handlers for work with external wallets.
12 tasks
erikd
approved these changes
Aug 24, 2018
KtorZ
added a commit
to input-output-hk/cardano-wallet-legacy
that referenced
this pull request
Nov 9, 2018
…hk/develop-new Make develop great again
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings back develop to what it was before the incident, minus CBR-97.