Skip to content
This repository was archived by the owner on Aug 18, 2020. It is now read-only.

Update CHANGELOG about changes in 1.5 (for the wallet backend) #4054

Merged
merged 1 commit into from
Jan 31, 2019

Conversation

KtorZ
Copy link
Contributor

@KtorZ KtorZ commented Jan 31, 2019

Description

Linked issue

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

How to merge

Send the message bors r+ to merge this PR. For more information, see
docs/how-to/bors.md.

@KtorZ KtorZ requested a review from tatyanavych January 31, 2019 14:31
@KtorZ KtorZ assigned KtorZ and unassigned tatyanavych Jan 31, 2019
Copy link
Contributor

@tatyanavych tatyanavych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few links that are closed. Are these correct?
cardano-foundation/cardano-wallet#110
#3700
#3809

@KtorZ
Copy link
Contributor Author

KtorZ commented Jan 31, 2019

Yes. At that time, we were still making PR against a "story" branch and then, merging the branch into develop. So there's effectively only one merge from sub PRs into develop. The others were merged (either via the GitHub interface or by hand) in an intermediate branch.

@KtorZ
Copy link
Contributor Author

KtorZ commented Jan 31, 2019

bors r+

iohk-bors bot added a commit that referenced this pull request Jan 31, 2019
3916: [DEVOPS-1131] automated proposal scripting r=mhuesch a=cleverca22

## Description

<!--- A brief description of this PR and the problem is trying to solve -->

## Linked issue

<!--- Put here the relevant issue from YouTrack -->



4050: Internal Endpoints Disclaimer r=KtorZ a=KtorZ

## Description

<!--- A brief description of this PR and the problem is trying to solve -->

As a follow-up from the discussion in cardano-foundation/cardano-wallet#151 (comment), we will add a proper disclaimer in the documentation about the internal endpoints. 

## Linked issue

<!--- Put here the relevant issue from YouTrack -->

cardano-foundation/cardano-wallet#228



4054: Update CHANGELOG about changes in 1.5 (for the wallet backend) r=KtorZ a=KtorZ

## Description

<!--- A brief description of this PR and the problem is trying to solve -->

## Linked issue

<!--- Put here the relevant issue from YouTrack -->



Co-authored-by: Michael Bishop <[email protected]>
Co-authored-by: Michael Hueschen <[email protected]>
Co-authored-by: KtorZ <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jan 31, 2019

@iohk-bors iohk-bors bot merged commit 52b5c95 into develop Jan 31, 2019
@iohk-bors iohk-bors bot deleted the KtorZ/changelog-1.5 branch January 31, 2019 21:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants