Skip to content

[SYCL][ASan] Mark PVC & DG2 as unsupported in E2E tests #14766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

kbenzie
Copy link
Contributor

@kbenzie kbenzie commented Jul 25, 2024

Following the merge of #13450 there were reports of failures on PVC & DG2:

This patch the suggestion in #14720 (comment) to disable AddressSanitizer testing on PVC & DG2 devices.

@kbenzie kbenzie requested a review from a team as a code owner July 25, 2024 09:51
@kbenzie kbenzie temporarily deployed to WindowsCILock July 25, 2024 09:52 — with GitHub Actions Inactive
@wenju-he
Copy link
Contributor

probably needs to disable on dg2 as well, failures in #13450 (comment) is on dg2

@kbenzie
Copy link
Contributor Author

kbenzie commented Jul 25, 2024

probably needs to disable on dg2 as well, failures in #13450 (comment) is on dg2

Do you know what feature name for that is @wenju-he ?

Edit: Nevermind, I should've used grep in the first place.

Following the merge of intel#13450 there
were reports of failures on PVC & DG2:

* intel#14720 (comment)
* intel#13450 (comment)

This patch the suggestion in
intel#14720 (comment) to
disable AddressSanitizer testing on PVC & DG2 devices.
@kbenzie kbenzie force-pushed the benie/asan-pvc-unsupported branch from 44b965c to a1c8beb Compare July 25, 2024 10:30
@kbenzie kbenzie changed the title [SYCL][ASan] Mark PVC as unsupported in E2E tests [SYCL][ASan] Mark PVC & DG2 as unsupported in E2E tests Jul 25, 2024
@kbenzie kbenzie temporarily deployed to WindowsCILock July 25, 2024 10:32 — with GitHub Actions Inactive
Copy link
Contributor

@wenju-he wenju-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kbenzie kbenzie temporarily deployed to WindowsCILock July 25, 2024 10:54 — with GitHub Actions Inactive
@steffenlarsen
Copy link
Contributor

Tag @AllanZyne for awareness.

@kbenzie
Copy link
Contributor Author

kbenzie commented Jul 25, 2024

@sarnex
Copy link
Contributor

sarnex commented Jul 25, 2024

@kbenzie I restarted the HIP runner and the HIP job in this PR, sorry for the trouble

@kbenzie
Copy link
Contributor Author

kbenzie commented Jul 25, 2024

@intel/llvm-gatekeepers please merge

@sarnex sarnex merged commit ecec9d1 into intel:sycl Jul 25, 2024
14 checks passed
hdelan pushed a commit to hdelan/llvm that referenced this pull request Jul 26, 2024
Following the merge of intel#13450 there
were reports of failures on PVC & DG2:

* intel#14720 (comment)
* intel#13450 (comment)

This patch the suggestion in
intel#14720 (comment) to
disable AddressSanitizer testing on PVC & DG2 devices.
@kbenzie kbenzie deleted the benie/asan-pvc-unsupported branch December 18, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants