Skip to content

[SYCL][Bindless] Extend image copies #16661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 31, 2025
Merged

[SYCL][Bindless] Extend image copies #16661

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8ae1437
[SYCL][Bindless] Extend image copies
DBDuncan Oct 23, 2024
c6475ae
Update UR link
DBDuncan Jan 16, 2025
ebe2700
Make most handler.cpp helper functions static and remote else after r…
DBDuncan Jan 23, 2025
ad2d9cb
Merge remote-tracking branch 'origin/sycl' into duncan/extend-bindles…
DBDuncan Jan 27, 2025
a91672b
Update UR commit
DBDuncan Jan 27, 2025
349a1b0
Merge remote-tracking branch 'origin/sycl' into duncan/extend-bindles…
DBDuncan Jan 31, 2025
ca53d2d
Update UR link and commit
DBDuncan Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sycl/cmake/modules/FetchUnifiedRuntime.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ if(SYCL_UR_USE_FETCH_CONTENT)
CACHE PATH "Path to external '${name}' adapter source dir" FORCE)
endfunction()

set(UNIFIED_RUNTIME_REPO "https://github.com/oneapi-src/unified-runtime.git")
set(UNIFIED_RUNTIME_REPO "https://github.com/DBDuncan/unified-runtime.git")
include(${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules/UnifiedRuntimeTag.cmake)

set(UMF_BUILD_EXAMPLES OFF CACHE INTERNAL "EXAMPLES")
Expand Down
2 changes: 1 addition & 1 deletion sycl/cmake/modules/UnifiedRuntimeTag.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@
# Date: Thu Jan 16 10:17:25 2025 +0000
# Merge pull request #2546 from lukaszstolarczuk/bump-umf-to-latest-main
# [main] Bump UMF to v0.10.1
set(UNIFIED_RUNTIME_TAG 023a84744b7db460d42225c8b5ea4d6def085c81)
set(UNIFIED_RUNTIME_TAG 3c462b4ddcdaef72b9bdf57b5fe18b965c5fad81)
318 changes: 275 additions & 43 deletions sycl/doc/extensions/experimental/sycl_ext_oneapi_bindless_images.asciidoc
View file
Open in desktop

Large diffs are not rendered by default.

350 changes: 322 additions & 28 deletions sycl/include/sycl/ext/oneapi/bindless_images.hpp
View file
Open in desktop

Large diffs are not rendered by default.

312 changes: 227 additions & 85 deletions sycl/include/sycl/handler.hpp
View file
Open in desktop

Large diffs are not rendered by default.

990 changes: 740 additions & 250 deletions sycl/include/sycl/queue.hpp
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion sycl/source/detail/memory_manager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1644,7 +1644,8 @@ void MemoryManager::copy_image_bindless(
"Copy image bindless must be called with a valid device queue");
assert((Flags == UR_EXP_IMAGE_COPY_FLAG_HOST_TO_DEVICE ||
Flags == UR_EXP_IMAGE_COPY_FLAG_DEVICE_TO_HOST ||
Flags == UR_EXP_IMAGE_COPY_FLAG_DEVICE_TO_DEVICE) &&
Flags == UR_EXP_IMAGE_COPY_FLAG_DEVICE_TO_DEVICE ||
Flags == UR_EXP_IMAGE_COPY_FLAG_HOST_TO_HOST) &&
"Invalid flags passed to copy_image_bindless.");
if (!Dst || !Src)
throw sycl::exception(
Expand Down
Loading
Loading