[UR] Make each profiling info variant for urEventGetProfilingInfo optional and improve its conformance test #17067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch turns all of the values returned by urEventGetProfilingInfo to be optional and updates adapters to handle this by returning the appropriate enum when it is not supported. The tests have also been updated, to ensure that returning a counter of "0" or values equal to the previous profiling event is no longer considered a failure.
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
frasercrmck
approved these changes
Feb 19, 2025
hvdijk
approved these changes
Feb 19, 2025
pbalcer
approved these changes
Feb 19, 2025
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
changed the title
|
@intel/llvm-gatekeepers Please merge. |
|
@RossBrunton post-commit is failing, please, fix ASAP. https://github.com/intel/llvm/actions/runs/13435147368/job/37535653157 |
I've retried the job, this looks like an issue we've seen before where the |
|
I've opened #17093 to hopefully stop this issue recurring. |
This was referenced Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated from oneapi-src/unified-runtime#2533
This patch turns all of the values returned by urEventGetProfilingInfo
to be optional and updates adapters to handle this by returning the
appropriate enum when it is not supported.
The tests have also been updated, to ensure that returning a counter of
"0" or values equal to the previous profiling event is no longer
considered a failure.