Skip to content

[SYCL][NFC] Cleanup BMG testing on Windows #17753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AlexeySachkov
Copy link
Contributor

This is a joined cherry-pick of #17347 and #17105 made to align disabled tests between sycl and sycl-rel-6_1_0 branches to make the pre-commit more stable on the latter.

Descriptions of cherry-picked commits:


[SYCL][Graph][E2E] Disable all Graph E2E testing on Windows Battlemage (#17348)

We currently only disable the RecordReplay variant of E2E testing on
battlemage, however we have many other tests and the likihood is that if
the RecordReplay tests are failing then other tests will start failing
too.

Disable all Graphs tests until Graph support on Windows battlemage can
be investigated more thoroughly.

See #17165

Patch-By: Ewan Crawford [email protected]


[CI] Add Windows BMG testing in precommit (#17105)

We got a Windows BMG machine, so add Windows BMG testing.

There are two categories of failures here: consistent failures/timeouts
and really slow tests causing CI to take 30min extra.

I disabled both of these and made two GH issues:
one,
two.

Patch-by: Sarnie, Nick [email protected]


EwanC and others added 2 commits March 31, 2025 11:22
intel#17348)

We currently only disable the RecordReplay variant of E2E testing on
battlemage, however we have many other tests and the likihood is that if
the RecordReplay tests are failing then other tests will start failing
too.

Disable all Graphs tests until Graph support on Windows battlemage can
be investigated more thoroughly.

See intel#17165
We got a Windows BMG machine, so add Windows BMG testing.

There are two categories of failures here: consistent failures/timeouts
and really slow tests causing CI to take 30min extra.

I disabled both of these and made two GH issues:
[one](intel#17165),
[two](intel#17255).

---------

Signed-off-by: Sarnie, Nick <[email protected]>
@AlexeySachkov AlexeySachkov changed the title [SYCL] Cleanup BMG testing on Windows [SYCL][NFC] Cleanup BMG testing on Windows Apr 1, 2025
@AlexeySachkov
Copy link
Contributor Author

Linux failures can be ignored - pre-commit isn't stable yet on 6.1 branch. The main benefit of this PR is reduced amount of failures on BMG Windows: comparing with reference #17067, there is only 1 remaining failure vs 81 in the reference PR

@AlexeySachkov AlexeySachkov marked this pull request as ready for review April 1, 2025 08:13
@AlexeySachkov AlexeySachkov requested review from a team as code owners April 1, 2025 08:13
Copy link
Contributor

@YuriPlyakhin YuriPlyakhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matrix-related changes lgtm

Copy link
Contributor

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JM changes LGTM

@AlexeySachkov
Copy link
Contributor Author

FAIL: SYCL :: bindless_images/dx12_interop/read_write_unsampled.cpp (2207 of 2227)
******************** TEST 'SYCL :: bindless_images/dx12_interop/read_write_unsampled.cpp' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 6
D:/github/_work/llvm/llvm/install/bin/clang++.exe  -Werror  -fsycl -fsycl-targets=spir[64](https://github.com/intel/llvm/actions/runs/14201293994/job/39790283968?pr=17753#step:15:65)  D:\github\_work\llvm\llvm\llvm\sycl\test-e2e\bindless_images\dx12_interop\read_write_unsampled.cpp  -ld3d12 -ldxgi -ldxguid  -o D:\github\_work\llvm\llvm\build-e2e\bindless_images\dx12_interop\Output\read_write_unsampled.cpp.tmp.out
# executed command: D:/github/_work/llvm/llvm/install/bin/clang++.exe -Werror -fsycl -fsycl-targets=spir64 'D:\github\_work\llvm\llvm\llvm\sycl\test-e2e\bindless_images\dx12_interop\read_write_unsampled.cpp' -ld3d12 -ldxgi -ldxguid -o 'D:\github\_work\llvm\llvm\build-e2e\bindless_images\dx12_interop\Output\read_write_unsampled.cpp.tmp.out'
# RUN: at line 7
env NEOReadDebugKeys=1 UseBindlessMode=1 UseExternalAllocatorForSshAndDsh=1 D:\github\_work\llvm\llvm\build-e2e\bindless_images\dx12_interop\Output\read_write_unsampled.cpp.tmp.out
# executed command: env NEOReadDebugKeys=1 UseBindlessMode=1 UseExternalAllocatorForSshAndDsh=1 'D:\github\_work\llvm\llvm\build-e2e\bindless_images\dx12_interop\Output\read_write_unsampled.cpp.tmp.out'
# .---command stderr------------
# | Tue Apr  1 11:07:15 2025: IGSC: (D:\qb\workspace\31779\source\igsc-master\lib\igsc_lib.c:gsc_driver_init():218) Error in HECI init (3)
# | Tue Apr  1 11:07:15 2025: IGSC: (D:\qb\workspace\31779\source\igsc-master\lib\igsc_lib.c:igsc_device_subsystem_ids():1597) Failed to init HECI driver
# | Tue Apr  1 11:07:18 2025: IGSC: (D:\qb\workspace\31779\source\igsc-master\lib\igsc_lib.c:gsc_driver_init():218) Error in HECI init (3)
# | Tue Apr  1 11:07:18 2025: IGSC: (D:\qb\workspace\31779\source\igsc-master\lib\igsc_lib.c:igsc_device_subsystem_ids():1597) Failed to init HECI driver
# | Test failed!
# `-----------------------------
# error: command failed with exit status: 1

--

Is the only remaining BMG failure. It is persistent, I don't think that we have seen something like that and it is not reproducible on sycl branch. I will take a look at it separately, but for now I will proceed with merge since this patch is an NFC, it only modifies our test infrastructure a little bit

@AlexeySachkov AlexeySachkov merged commit cb4f7ab into intel:sycl-rel-6_1_0 Apr 1, 2025
7 of 10 checks passed
@AlexeySachkov AlexeySachkov deleted the private/asachkov/stabilize-pre-commit-1 branch April 1, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants