-
Notifications
You must be signed in to change notification settings - Fork 769
[SYCL][NFC] Cleanup BMG testing on Windows #17753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][NFC] Cleanup BMG testing on Windows #17753
Conversation
intel#17348) We currently only disable the RecordReplay variant of E2E testing on battlemage, however we have many other tests and the likihood is that if the RecordReplay tests are failing then other tests will start failing too. Disable all Graphs tests until Graph support on Windows battlemage can be investigated more thoroughly. See intel#17165
We got a Windows BMG machine, so add Windows BMG testing. There are two categories of failures here: consistent failures/timeouts and really slow tests causing CI to take 30min extra. I disabled both of these and made two GH issues: [one](intel#17165), [two](intel#17255). --------- Signed-off-by: Sarnie, Nick <[email protected]>
Linux failures can be ignored - pre-commit isn't stable yet on 6.1 branch. The main benefit of this PR is reduced amount of failures on BMG Windows: comparing with reference #17067, there is only 1 remaining failure vs 81 in the reference PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matrix-related changes lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JM changes LGTM
Is the only remaining BMG failure. It is persistent, I don't think that we have seen something like that and it is not reproducible on |
This is a joined cherry-pick of #17347 and #17105 made to align disabled tests between
sycl
andsycl-rel-6_1_0
branches to make the pre-commit more stable on the latter.Descriptions of cherry-picked commits:
[SYCL][Graph][E2E] Disable all Graph E2E testing on Windows Battlemage (#17348)
We currently only disable the RecordReplay variant of E2E testing on
battlemage, however we have many other tests and the likihood is that if
the RecordReplay tests are failing then other tests will start failing
too.
Disable all Graphs tests until Graph support on Windows battlemage can
be investigated more thoroughly.
See #17165
Patch-By: Ewan Crawford [email protected]
[CI] Add Windows BMG testing in precommit (#17105)
We got a Windows BMG machine, so add Windows BMG testing.
There are two categories of failures here: consistent failures/timeouts
and really slow tests causing CI to take 30min extra.
I disabled both of these and made two GH issues:
one,
two.
Patch-by: Sarnie, Nick [email protected]