[UR][L0] Fix runtime library linkage failure #17347
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbalcer
reviewed
Mar 7, 2025
| @@ -63,6 +63,22 @@ if (NOT DEFINED LEVEL_ZERO_LIBRARY OR NOT DEFINED LEVEL_ZERO_INCLUDE_DIR) | |||
| FetchContent_MakeAvailable(level-zero-loader) | |||
| FetchContent_GetProperties(level-zero-loader) | |||
|
|
|||
| if(WIN32 AND level-zero-loader_SOURCE_DIR) | |||
| # apply runtime library patch | |||
There was a problem hiding this comment.
this probably should be under if(MSVC). Also, instead of patching the cmakes, isn't it possible to replace the CXX_FLAGS variables?
There was a problem hiding this comment.
Done, works locally
PatKamin
force-pushed
the
fix-runtime-lib
branch
from
55777ab to
00e27fe
Compare
Fix failure of mismatching runtime library types when linking ur_adapter_level_zero.dll with ze_loader.lib.
PatKamin
force-pushed
the
fix-runtime-lib
branch
from
00e27fe to
06b0c41
Compare
|
Failure in SYCL Pre Commit on Linux job not related with changes from this PR which affect Windows only. |
|
Closing in favor of #17366 |
AlexeySachkov
added a commit
that referenced
this pull request
Apr 1, 2025
This is a joined cherry-pick of #17347 and #17105 made to align disabled tests between `sycl` and `sycl-rel-6_1_0` branches to make the pre-commit more stable on the latter. Descriptions of cherry-picked commits: --- [SYCL][Graph][E2E] Disable all Graph E2E testing on Windows Battlemage (#17348) We currently only disable the RecordReplay variant of E2E testing on battlemage, however we have many other tests and the likihood is that if the RecordReplay tests are failing then other tests will start failing too. Disable all Graphs tests until Graph support on Windows battlemage can be investigated more thoroughly. See #17165 Patch-By: Ewan Crawford <[email protected]> --- [CI] Add Windows BMG testing in precommit (#17105) We got a Windows BMG machine, so add Windows BMG testing. There are two categories of failures here: consistent failures/timeouts and really slow tests causing CI to take 30min extra. I disabled both of these and made two GH issues: [one](#17165), [two](#17255). Patch-by: Sarnie, Nick <[email protected]> ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix failure of mismatching runtime library types when linking ur_adapter_level_zero.dll with ze_loader.lib.