Skip to content

[SYCL][Graph] Disable all Graph E2E testing on Windows Battlemage #17348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

EwanC
Copy link
Contributor

@EwanC EwanC commented Mar 7, 2025

We currently only disable the RecordReplay variant of E2E testing on battlemage, however we have many other tests and the likihood is that if the RecordReplay tests are failing then other tests will start failing too.

Disable all Graphs tests until Graph support on Windows battlemage can be investigated more thoroughly.

See #17165

@EwanC EwanC temporarily deployed to WindowsCILock March 7, 2025 10:15 — with GitHub Actions Inactive
@EwanC EwanC temporarily deployed to WindowsCILock March 7, 2025 10:44 — with GitHub Actions Inactive
@EwanC EwanC temporarily deployed to WindowsCILock March 7, 2025 10:44 — with GitHub Actions Inactive
@EwanC EwanC marked this pull request as ready for review March 7, 2025 11:13
@EwanC EwanC requested a review from a team as a code owner March 7, 2025 11:13
@EwanC EwanC requested a review from konradkusiak97 March 7, 2025 11:13
We currently only disable the RecordReplay variant of E2E testing
on battlemage, however we have many other tests and the likihood is
that if the RecordReplay tests are failing then other tests will
start failing too.

Disable all Graphs tests until Graph support on Windows battlemage
can be investigated more thoroughly.
@EwanC EwanC force-pushed the ewan/graph_windows_bmg_disable branch from 054f1b7 to 79ee540 Compare March 7, 2025 15:02
@EwanC EwanC temporarily deployed to WindowsCILock March 7, 2025 15:03 — with GitHub Actions Inactive
@sarnex
Copy link
Contributor

sarnex commented Mar 7, 2025

@EwanC Okay if I merge this now to fix possible CI instability? Thx

@EwanC
Copy link
Contributor Author

EwanC commented Mar 7, 2025

@EwanC Okay if I merge this now to fix possible CI instability? Thx

yup, go for it

@sarnex
Copy link
Contributor

sarnex commented Mar 7, 2025

thx!

@sarnex sarnex merged commit acfbc00 into intel:sycl Mar 7, 2025
9 of 11 checks passed
@EwanC EwanC temporarily deployed to WindowsCILock March 7, 2025 16:08 — with GitHub Actions Inactive
@EwanC EwanC temporarily deployed to WindowsCILock March 7, 2025 16:08 — with GitHub Actions Inactive
AlexeySachkov pushed a commit to AlexeySachkov/llvm that referenced this pull request Mar 31, 2025
intel#17348)

We currently only disable the RecordReplay variant of E2E testing on
battlemage, however we have many other tests and the likihood is that if
the RecordReplay tests are failing then other tests will start failing
too.

Disable all Graphs tests until Graph support on Windows battlemage can
be investigated more thoroughly.

See intel#17165
AlexeySachkov added a commit that referenced this pull request Apr 1, 2025
This is a joined cherry-pick of #17347 and #17105
made to align disabled tests between `sycl` and `sycl-rel-6_1_0`
branches to make the pre-commit more stable on the latter.

Descriptions of cherry-picked commits:

---

[SYCL][Graph][E2E] Disable all Graph E2E testing on Windows Battlemage
(#17348)

We currently only disable the RecordReplay variant of E2E testing on
battlemage, however we have many other tests and the likihood is that if
the RecordReplay tests are failing then other tests will start failing
too.

Disable all Graphs tests until Graph support on Windows battlemage can
be investigated more thoroughly.

See #17165

Patch-By: Ewan Crawford <[email protected]>

---

[CI] Add Windows BMG testing in precommit (#17105)

We got a Windows BMG machine, so add Windows BMG testing.

There are two categories of failures here: consistent failures/timeouts
and really slow tests causing CI to take 30min extra.

I disabled both of these and made two GH issues:
[one](#17165),
[two](#17255).

Patch-by: Sarnie, Nick <[email protected]>

---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants