Skip to content

Create documentation for ControllerModifyVolume and controller default #1836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2024
Merged

Create documentation for ControllerModifyVolume and controller default #1836

merged 1 commit into from
Sep 24, 2024

Conversation

travisyx
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design

/kind documentation

/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

This PR adds a user guide for ControllerModifyVolume. Additionally, this adds command line argument defaults for which disk types support metadata updates. This also fixes a typo in test/run-k8s-integration-ci.sh.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 23, 2024
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 23, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @travisyx. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 23, 2024
@travisyx travisyx marked this pull request as draft September 23, 2024 20:36
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2024
@travisyx travisyx changed the title Create documentation for ControllerModifyVolume and controller default [WIP] Create documentation for ControllerModifyVolume and controller default Sep 23, 2024
@travisyx travisyx marked this pull request as ready for review September 23, 2024 20:45
@travisyx travisyx changed the title [WIP] Create documentation for ControllerModifyVolume and controller default Create documentation for ControllerModifyVolume and controller default Sep 23, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2024
@amacaskill
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 23, 2024
@amacaskill
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amacaskill, travisyx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2024
@k8s-ci-robot k8s-ci-robot merged commit 51b78e4 into kubernetes-sigs:master Sep 24, 2024
7 checks passed
@travisyx travisyx mentioned this pull request Nov 5, 2024
Merged
k8s-ci-robot added a commit that referenced this pull request Nov 5, 2024
@k8s-ci-robot
Merge pull request #1861 from travisyx/automated-cherry-pick-of-#1826-#…
caa3eae 
…1836-#1838-#1841-upstream-release-1.15

Automated cherry pick of #1826: Add ControllerModifyVolume E2E tests
#1836: Create documentation for ControllerModifyVolume and controller default
#1838: Enable VolumeAttributesClass feature gate for CI runs
#1841: Update logic to use SI for VACs
@travisyx travisyx mentioned this pull request Nov 7, 2024
Closed
travisyx added a commit to travisyx/gcp-compute-persistent-disk-csi-driver that referenced this pull request Nov 12, 2024
@travisyx
Revert "Automated cherry pick of kubernetes-sigs#1826: Add Controller…
48fc6f4 
…ModifyVolume E2E tests

kubernetes-sigs#1836: Create documentation for ControllerModifyVolume and controller default
kubernetes-sigs#1838: Enable VolumeAttributesClass feature gate for CI runs
kubernetes-sigs#1841: Update logic to use SI for VACs"
amacaskill added a commit that referenced this pull request Nov 13, 2024
@amacaskill
Merge pull request #1869 from travisyx/revert-1861-automated-cherry-p…
d5e7f0c 
…ick-of-#1826-#1836-#1838-#1841-upstream-release-1.15

Revert "Automated cherry pick of #1826: Add ControllerModifyVolume E2E tests#1836: Create documentation for ControllerModifyVolume and controller default#1838: Enable VolumeAttributesClass feature gate for CI runs#1841: Update logic to use SI for VACs"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amacaskill amacaskill amacaskill left review comments

@saikat-royc saikat-royc Awaiting requested review from saikat-royc

@songjiaxun songjiaxun Awaiting requested review from songjiaxun

@mattcary mattcary Awaiting requested review from mattcary

@tyuchn tyuchn Awaiting requested review from tyuchn

Assignees

@amacaskill amacaskill

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@travisyx @k8s-ci-robot @amacaskill