Update logic to use SI for VACs

[travisyx]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

This PR updates the logic to accept SI units for throughput for VolumeAttributesClasses. This makes the VACs consistent with SI being used in other areas, such as in StorageClasses. This also removes the duplicate definition of the command line arguments in the dev overlay.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

This feature changes VolumeAttributesClass, so throughput specifications will need "Mi".

[k8s-ci-robot]

Hi @travisyx. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[amacaskill]

/ok-to-test

[amacaskill]

Why is this / driver-args.yaml being deleted?

[travisyx]

There shouldn't be a need for the driver-args as the command line arguments are in the base controller.yaml.

[amacaskill]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amacaskill, heikofkoehler, travisyx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [amacaskill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[travisyx]

/cherry-pick release-1.15

[k8s-infra-cherrypick-robot]

@travisyx: only kubernetes-sigs org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mattcary]

/cherry-pick release-1.15

lgtm

[k8s-infra-cherrypick-robot]

@mattcary: #1841 failed to apply on top of branch "release-1.15":

Applying: Update logic to use SI for VACs
Using index info to reconstruct a base tree...
A	examples/kubernetes/demo-vol-create.yaml
M	test/e2e/tests/single_zone_e2e_test.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/tests/single_zone_e2e_test.go
CONFLICT (content): Merge conflict in test/e2e/tests/single_zone_e2e_test.go
CONFLICT (modify/delete): examples/kubernetes/demo-vol-create.yaml deleted in HEAD and modified in Update logic to use SI for VACs. Version Update logic to use SI for VACs of examples/kubernetes/demo-vol-create.yaml left in tree.
Removing deploy/kubernetes/overlays/dev/driver-args.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Update logic to use SI for VACs

In response to this:

/cherry-pick release-1.15

lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mattcary]

@travisyx looks like it can't cherry-pick cleanly, you'll have to make a PR by running git cherry-pick manually & clean up the merge conflicts.