Skip to content

Removed files from sig-security #6176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2021
Merged

Removed files from sig-security #6176

merged 1 commit into from
Nov 18, 2021

Conversation

chetak123
Copy link
Member

Which issue(s) this PR fixes: kubernetes/sig-security#9

Fixes # Removed and moved sig-security-docs/OWNERS, sig-security-external-audit, security-audit-2019, security-audit-2021, sig-security-tooling/OWNERS to sig-security

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 21, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @chetak123!

It looks like this is your first PR to kubernetes/community 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/community has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @chetak123. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. sig/security Categorizes an issue or PR as relevant to SIG Security. labels Oct 21, 2021
@PushkarJ
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 21, 2021
@PushkarJ PushkarJ mentioned this pull request Oct 21, 2021
Merged
@PushkarJ
Copy link
Member

/lgtm
/cc @reylejano @savitharaghunathan
/assign IanColdwater tabbysable

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2021
@savitharaghunathan
Copy link
Member

savitharaghunathan commented Oct 21, 2021 •
edited
Loading

/lgtm

Thanks @chetak123

Everything looks good, you might want to squash the commits.

@PushkarJ
Copy link
Member

/label tide/merge-method-squash

(Trying this label for squashing the commits)

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 21, 2021
@savitharaghunathan
Copy link
Member

/label tide/merge-method-squash

(Trying this label for squashing the commits)

Nice label magic!

@reylejano
Copy link
Member

/hold until kubernetes/sig-security#12 merges

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2021
@chetak123
removed owners and sig-security-external-audit
3d54bb2 
Signed-off-by: Ayushman <[email protected]>

removed security-tooling/owners security-audit-2019 security-audit-2021

Signed-off-by: Ayushman <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2021
@PushkarJ
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2021
@PushkarJ PushkarJ removed their assignment Oct 22, 2021
@tabbysable
Copy link
Member

/approve

Thanks for the help @chetak123

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chetak123, tabbysable

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2021
@PushkarJ
Copy link
Member

/unhold for kubernetes/sig-security#12 (comment)

@PushkarJ
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2021
@k8s-ci-robot k8s-ci-robot merged commit 282eb7e into kubernetes:master Nov 18, 2021
@PushkarJ PushkarJ mentioned this pull request Nov 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PushkarJ PushkarJ Awaiting requested review from PushkarJ

@reylejano reylejano Awaiting requested review from reylejano

@savitharaghunathan savitharaghunathan Awaiting requested review from savitharaghunathan

Assignees

@savitharaghunathan savitharaghunathan

@IanColdwater IanColdwater

@tabbysable tabbysable

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/security Categorizes an issue or PR as relevant to SIG Security. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@chetak123 @k8s-ci-robot @PushkarJ @savitharaghunathan @reylejano @tabbysable @IanColdwater