Skip to content

Move artifacts from k/community to k/sig-security #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PushkarJ opened this issue Oct 20, 2021 · 6 comments
Closed

Move artifacts from k/community to k/sig-security #9

PushkarJ opened this issue Oct 20, 2021 · 6 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/security Categorizes an issue or PR as relevant to SIG Security.

Comments

@PushkarJ
Copy link
Member

PushkarJ commented Oct 20, 2021

What?

Create the following set of directory structure:

k/sig-security:

How?
This will need two set of PRs, one to remove stuff from k/community and one to add the same stuff to k/sig-security

Why do this?
This will unblock following PRs: kubernetes/community#6140 and kubernetes/community#5853. More importantly, it will allow allow sig-security artifacts to have a single landing page.

Anything else you would like to add @tabbysable @IanColdwater @reylejano @savitharaghunathan ?

/sig security
/kind cleanup
/label good first issue
/label help wanted

@k8s-ci-robot k8s-ci-robot added sig/security Categorizes an issue or PR as relevant to SIG Security. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Oct 20, 2021
@PushkarJ
Copy link
Member Author

/help
/good-first-issue

(trying again)

@k8s-ci-robot
Copy link
Contributor

@PushkarJ:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/help
/good-first-issue

(trying again)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Oct 20, 2021
@chetak123
Copy link
Member

/assign @chetak123

@tabbysable
Copy link
Member

tabbysable commented Nov 6, 2021

@PushkarJ when I was reviewing #12 I asked for the directory structure to be matched to the old one from k/community, but now I see here you requested it specifically. So, I wanna bring this up so that @chetak123 isn't getting mixed messages.

I think that because our subproject names are fairly general terms on their own (docs and tooling especially) that it could be a little misleading to have the directory names as just those short words. Therefore, I like the old names that match the slack channel names better.

I don't want to dictate that, though-- WDYT about my idea of keeping the directory names the same as before?

@PushkarJ
Copy link
Member Author

PushkarJ commented Nov 6, 2021

Hi Tabby, thank you for reviewing!! I did not think about mapping the directory names to channel names for consistency earlier but I like the idea. Changed the original description as per your suggestion now.

@chetak123 please go ahead and make the renaming changes @tabbysable suggested in the PR for adding new files and then we should be good to go

@PushkarJ
Copy link
Member Author

With #12 and kubernetes/community#6176 merged, closing this ticket. Thank you again @chetak123 for working on this!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/security Categorizes an issue or PR as relevant to SIG Security.
Projects
None yet
Development

No branches or pull requests

4 participants