Skip to content

added files to sig-security #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Conversation

chetak123
Copy link
Member

Signed-off-by: Ayushman [email protected]

issue #9

Created new directories and files in sig-security

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 21, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @chetak123!

It looks like this is your first PR to kubernetes/sig-security 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/sig-security has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 21, 2021
@PushkarJ
Copy link
Member

/lgtm
/assign IanColdwater tabbysable
/cc @savitharaghunathan @reylejano
/hold for kubernetes/community#6176

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2021
@savitharaghunathan
Copy link
Member

I feel like we should remove the hold from this PR. k/community issue is waiting on getting this PR merged.

Personally I would like the content to be available here, before we remove it from k/community. @PushkarJ @reylejano what do you all think?

@PushkarJ
Copy link
Member

Maybe we can keep the /hold on both until we get /approve from Ian and Tabby? Once both the PRs are approved, we can unhold them together, thus avoiding two places having same content at the same time, even if it is for a short period.

@PushkarJ PushkarJ removed their assignment Oct 22, 2021
@reylejano
Copy link
Member

I agree we can wait till both PRs are approved and unhold together

@tabbysable
Copy link
Member

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2021
@tabbysable
Copy link
Member

tabbysable commented Nov 6, 2021

I've asked for a few changes to make the new directories consistent with the ones from the old repo.

Once you've done that, you can avoid needing to manually squash your commits by using magic similar to what @PushkarJ did in kubernetes/community#6176

Thanks a lot, @chetak123!

docs/OWNERS Outdated
@@ -0,0 +1,6 @@
# See the OWNERS docs at https://go.k8s.io/owners
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chetak123 can you please rename this directory to sig-security-docs to match the previous one under k/community?

It seems a little silly since this is now our sig-security repo, but I'm afraid that a "docs" subdirectory sounds like it's documentation about us or something, rather than the name of a subproject like it is.

@@ -0,0 +1,118 @@
# Request for Proposal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chetak123 Similarly, can you please rename this directory to sig-security-external-audit for consistency with the files' previous home in the k/community repo?

@@ -0,0 +1,6 @@
# See the OWNERS docs at https://go.k8s.io/owners
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chetak123 After renaming third party audit to sig-security-external-audit, can you please move these 3 files (owners, readme, and roadmap) up one level and remove the resulting empty directory?

tooling/OWNERS Outdated
@@ -0,0 +1,7 @@
# See the OWNERS docs at https://go.k8s.io/owners
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chetak123 As with the other two directories, please rename this one to sig-security-tooling for consistency with the old directory

@tabbysable
Copy link
Member

/remove-approve

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2021
Signed-off-by: Ayushman <[email protected]>

Directories Renamed

Signed-off-by: Ayushman <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2021
@PushkarJ
Copy link
Member

@chetak123 thank you for the fixes in naming!!
/lgtm
@tabbysable ready for your review

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2021
@tabbysable
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chetak123, tabbysable

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2021
@PushkarJ
Copy link
Member

/unhold for kubernetes/community#6176 (comment)

@PushkarJ
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2021
@k8s-ci-robot k8s-ci-robot merged commit 6f1cec8 into kubernetes:main Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants