-
Notifications
You must be signed in to change notification settings - Fork 65
added files to sig-security #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Welcome @chetak123! |
/lgtm |
I feel like we should remove the hold from this PR. k/community issue is waiting on getting this PR merged. Personally I would like the content to be available here, before we remove it from k/community. @PushkarJ @reylejano what do you all think? |
Maybe we can keep the |
I agree we can wait till both PRs are approved and unhold together |
/approve |
I've asked for a few changes to make the new directories consistent with the ones from the old repo. Once you've done that, you can avoid needing to manually squash your commits by using magic similar to what @PushkarJ did in kubernetes/community#6176 Thanks a lot, @chetak123! |
docs/OWNERS
Outdated
@@ -0,0 +1,6 @@ | |||
# See the OWNERS docs at https://go.k8s.io/owners |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chetak123 can you please rename this directory to sig-security-docs to match the previous one under k/community?
It seems a little silly since this is now our sig-security repo, but I'm afraid that a "docs" subdirectory sounds like it's documentation about us or something, rather than the name of a subproject like it is.
@@ -0,0 +1,118 @@ | |||
# Request for Proposal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chetak123 Similarly, can you please rename this directory to sig-security-external-audit
for consistency with the files' previous home in the k/community repo?
@@ -0,0 +1,6 @@ | |||
# See the OWNERS docs at https://go.k8s.io/owners |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chetak123 After renaming third party audit
to sig-security-external-audit
, can you please move these 3 files (owners, readme, and roadmap) up one level and remove the resulting empty directory?
tooling/OWNERS
Outdated
@@ -0,0 +1,7 @@ | |||
# See the OWNERS docs at https://go.k8s.io/owners |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chetak123 As with the other two directories, please rename this one to sig-security-tooling
for consistency with the old directory
/remove-approve |
Signed-off-by: Ayushman <[email protected]> Directories Renamed Signed-off-by: Ayushman <[email protected]>
@chetak123 thank you for the fixes in naming!! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chetak123, tabbysable The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold for kubernetes/community#6176 (comment) |
/hold cancel |
Signed-off-by: Ayushman [email protected]
issue #9
Created new directories and files in sig-security