[TableGen][SubtargetEmitter] Early exit from loop in FindWriteResources and FindReadAdvance #92202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelmaitland
requested review from
mshockwave,
topperc,
fpetrogalli and
tmatheson-arm
topperc
reviewed
May 15, 2024
| @@ -910,6 +910,7 @@ SubtargetEmitter::FindWriteResources(const CodeGenSchedRW &SchedWrite, | |||
| ProcModel.ModelName); | |||
| } | |||
| ResDef = WR; | |||
| break; | |||
There was a problem hiding this comment.
Doesn't this make the PrintFatalError dead code?
There was a problem hiding this comment.
I messed up. Need to take a second look at this.
There was a problem hiding this comment.
I have addressed this problem
This gives us a 26% speed improvement in our downstream.
michaelmaitland
force-pushed
the
early-exit-find-write-resource
branch
from
d947224 to
3fc1d3e
Compare
michaelmaitland
changed the title
michaelmaitland
force-pushed
the
early-exit-find-write-resource
branch
from
3fc1d3e to
3432c73
Compare
michaelmaitland
force-pushed
the
early-exit-find-write-resource
branch
from
3432c73 to
6b710d0
Compare
topperc
reviewed
May 15, 2024
| if (!AliasDef && SchedWrite.TheDef == WR->getValueAsDef("WriteType")) { | ||
| ResDef = WR; | ||
| break; | ||
| } else if (AliasDef == WR->getValueAsDef("WriteType")) { |
There was a problem hiding this comment.
No else needed after break
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
topperc
reviewed
May 15, 2024
topperc
reviewed
May 15, 2024
| // there is no need to verify whether there are resources defined for both | ||
| // SchedWrite and its alias. | ||
| Record *WRDef = WR->getValueAsDef("WriteType"); | ||
| if (!AliasDef && SchedWrite.TheDef == WRDef) { |
There was a problem hiding this comment.
What if AliasDef is non-null. We won't update ResDef if SchedWrite.TheDef == WRDef.
Suggested change
| if (!AliasDef && SchedWrite.TheDef == WRDef) { | |
| Record *WRDef = WR->getValueAsDef("WriteType"); | |
| if (AliasDef == WRDef || SchedWrite.TheDef == WRDef) { | |
| if (ResDef) | |
| PrintFatalError... | |
| ResDef = WR; | |
| // If there is no AliasDef and we find a match, we can early exit... | |
| if (!AliasDef) | |
| break; |
michaelmaitland
force-pushed
the
early-exit-find-write-resource
branch
from
4ffd8fa to
2b6aa35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives us a 30% speed improvement in our downstream.