Skip to content

chore: Adds HTTP status check helper methods #3035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 7, 2025
Merged

chore: Adds HTTP status check helper methods #3035

merged 2 commits into from
Feb 7, 2025

Conversation

maastha
Copy link
Collaborator

@maastha maastha commented Feb 6, 2025

Description

Adds HTTP status check helper methods

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@maastha maastha marked this pull request as ready for review February 6, 2025 14:02
@maastha maastha requested a review from a team as a code owner February 6, 2025 14:02
lantoli
lantoli approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@lantoli lantoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after changing package

EspenAlbert
EspenAlbert approved these changes Feb 7, 2025 •
edited
Loading
View reviewed changes
@maastha
Copy link
Collaborator Author

maastha commented Feb 7, 2025

Merging as test failures are generic across cloud-dev right now

@maastha maastha merged commit 5fa0e1f into master Feb 7, 2025
31 of 40 checks passed
@maastha maastha deleted the http-status-check branch February 7, 2025 15:31
lantoli added a commit that referenced this pull request Feb 12, 2025
@lantoli
Merge branch 'master' into CLOUDP-274025-dev-docs-examples
1641a4b 
* master:
  doc: Renames env var to `MONGODB_ATLAS_PREVIEW_PROVIDER_V2_ADVANCED_CLUSTER` (#3062)
  chore: Updates Atlas Go SDK (#3053)
  test: Tenant clusters with disk_size_gb is always 5 now (#3057)
  chore: Updates CHANGELOG.md for #3051
  fix: Removes `interval_min` plan modifier to avoid error on update (#3051)
  build(deps): bump go.mongodb.org/atlas-sdk (#3049)
  doc: Adds pinned_fcv.version as exported attribute in cluster and advanced cluster resource (#3047)
  update Go to 1.23.6 (#3045)
  chore: Adds HTTP status check helper methods (#3035)
  chore: Adds import checks to tests (#3039)
  chore: Updates CHANGELOG.md header for v1.26.1 release
  chore: Updates examples link in index.md for v1.26.1 release
  fix: Adds "state_name" to keepUnknown list to prevent copying volatile attributes from state (#3040)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lantoli lantoli lantoli approved these changes

@EspenAlbert EspenAlbert EspenAlbert approved these changes

@marcosuma marcosuma marcosuma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maastha @lantoli @EspenAlbert @marcosuma