Skip to content

test: Tenant clusters with disk_size_gb is always 5 now #3057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 12, 2025
Merged

test: Tenant clusters with disk_size_gb is always 5 now #3057

merged 2 commits into from
Feb 12, 2025

Conversation

oarbusi
Copy link
Collaborator

@oarbusi oarbusi commented Feb 12, 2025 •
edited
Loading

Description

Tenant clusters with disk_size_gb is always 5 now.
Since the shimming logic is in place, all M2 and M5 clusters are flex clusters which have disk_size_gb 5. Changing the relevant tests accordingly

TestAccCluster_tenant
    resource_cluster_test.go:1029: Step 1/2 error: Check failed: Check 4/5 error: mongodbatlas_cluster.tenant: Attribute 'disk_size_gb' expected "2", got "5"

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@oarbusi oarbusi requested a review from a team as a code owner February 12, 2025 09:09
EspenAlbert
EspenAlbert reviewed Feb 12, 2025
View reviewed changes
internal/service/cluster/resource_cluster_test.go
@@ -1023,7 +1023,7 @@ func TestAccCluster_withAutoScalingAWS(t *testing.T) {
func TestAccCluster_tenant(t *testing.T) {
var (
resourceName = "mongodbatlas_cluster.tenant"
projectID, clusterName = acc.ProjectIDExecutionWithCluster(t, 3)
projectID, clusterName = acc.ProjectIDExecutionWithCluster(t, 1)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup

@oarbusi oarbusi merged commit c499ba9 into master Feb 12, 2025
40 checks passed
@oarbusi oarbusi deleted the shared-tier-test branch February 12, 2025 10:38
lantoli added a commit that referenced this pull request Feb 12, 2025
@lantoli
Merge branch 'master' into CLOUDP-274025-dev-docs-examples
1641a4b 
* master:
  doc: Renames env var to `MONGODB_ATLAS_PREVIEW_PROVIDER_V2_ADVANCED_CLUSTER` (#3062)
  chore: Updates Atlas Go SDK (#3053)
  test: Tenant clusters with disk_size_gb is always 5 now (#3057)
  chore: Updates CHANGELOG.md for #3051
  fix: Removes `interval_min` plan modifier to avoid error on update (#3051)
  build(deps): bump go.mongodb.org/atlas-sdk (#3049)
  doc: Adds pinned_fcv.version as exported attribute in cluster and advanced cluster resource (#3047)
  update Go to 1.23.6 (#3045)
  chore: Adds HTTP status check helper methods (#3035)
  chore: Adds import checks to tests (#3039)
  chore: Updates CHANGELOG.md header for v1.26.1 release
  chore: Updates examples link in index.md for v1.26.1 release
  fix: Adds "state_name" to keepUnknown list to prevent copying volatile attributes from state (#3040)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EspenAlbert EspenAlbert EspenAlbert approved these changes

@marcosuma marcosuma marcosuma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oarbusi @EspenAlbert @marcosuma