fix: Removes interval_min plan modifier to avoid error on update
#3051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
APIx bot: a message has been sent to Docs Slack channel |
EspenAlbert
reviewed
Feb 11, 2025
| @@ -464,6 +463,46 @@ func TestAccConfigRSAlertConfiguration_withPagerDuty(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func TestAccConfigRSAlertConfiguration_withEmailToPagerDuty(t *testing.T) { | |||
EspenAlbert
approved these changes
Feb 11, 2025
lantoli
reviewed
Feb 11, 2025
internal/service/alertconfiguration/resource_alert_configuration_test.go
Outdated
Show resolved
Hide resolved
lantoli
approved these changes
Feb 11, 2025
EspenAlbert
reviewed
Feb 11, 2025
| @@ -283,9 +283,6 @@ func (r *alertConfigurationRS) Schema(ctx context.Context, req resource.SchemaRe | |||
| "interval_min": schema.Int64Attribute{ | |||
| Optional: true, | |||
| Computed: true, | |||
| PlanModifiers: []planmodifier.Int64{ | |||
There was a problem hiding this comment.
An alternative fix would be using requireReplace on changes to type_name that might handle more cases where UseStateForUnknown is not safe
There was a problem hiding this comment.
Since there is the Update API available, I think it's better to follow standard update behavior
There was a problem hiding this comment.
is there any chance this UseStateForUnknown was needed for something else?
There was a problem hiding this comment.
From the PR where it was introduced I see that it was only to reduce plan verbosity
…on_test.go Co-authored-by: Leo Antoli <[email protected]>
maastha
approved these changes
Feb 11, 2025
svc-apix-Bot
added a commit
that referenced
this pull request
Feb 12, 2025
lantoli
added a commit
that referenced
this pull request
Feb 12, 2025
* master: doc: Renames env var to `MONGODB_ATLAS_PREVIEW_PROVIDER_V2_ADVANCED_CLUSTER` (#3062) chore: Updates Atlas Go SDK (#3053) test: Tenant clusters with disk_size_gb is always 5 now (#3057) chore: Updates CHANGELOG.md for #3051 fix: Removes `interval_min` plan modifier to avoid error on update (#3051) build(deps): bump go.mongodb.org/atlas-sdk (#3049) doc: Adds pinned_fcv.version as exported attribute in cluster and advanced cluster resource (#3047) update Go to 1.23.6 (#3045) chore: Adds HTTP status check helper methods (#3035) chore: Adds import checks to tests (#3039) chore: Updates CHANGELOG.md header for v1.26.1 release chore: Updates examples link in index.md for v1.26.1 release fix: Adds "state_name" to keepUnknown list to prevent copying volatile attributes from state (#3040)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
avoids error when updating from an email notification to a 'PAGER_DUTY', 'OPS_GENIE' or 'VICTOR_OPS' that require
interval_minattribute to not be setLink to any related issue(s): HELP-70810
Type of change:
Required Checklist:
Further comments