Skip to content

doc: Update guidelines for external contributors to squash commits #3243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 4, 2025
Merged

doc: Update guidelines for external contributors to squash commits #3243

merged 2 commits into from
Apr 4, 2025

Conversation

maastha
Copy link
Collaborator

@maastha maastha commented Apr 2, 2025

Description

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@maastha maastha marked this pull request as ready for review April 2, 2025 13:37
@maastha maastha requested a review from a team as a code owner April 2, 2025 13:37
oarbusi
oarbusi approved these changes Apr 3, 2025
View reviewed changes
Copy link
Collaborator

@oarbusi oarbusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a bit of context on why we recommend this in the description of the PR would be helpful for future reference

@maastha maastha merged commit e95c70f into master Apr 4, 2025
44 checks passed
@maastha maastha deleted the maastha-patch-1 branch April 4, 2025 21:36
lantoli added a commit that referenced this pull request Apr 8, 2025
@lantoli
Merge branch 'master' into remove_lint_exceptions
891c570 
* master:
  chore: Updates org_clean_test.go to delete stream instances & private endpoint services (#3252)
  chore: Updates organization.md `skip_default_alerts_settings` note format (#3246)
  doc: Update guidelines for external contributors to squash commits (#3243)
  chore: Updates CHANGELOG.md for #3199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lantoli lantoli lantoli approved these changes

@oarbusi oarbusi oarbusi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maastha @lantoli @oarbusi