chore: Updates org_clean_test.go to delete stream instances & private endpoint services #3252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lantoli
reviewed
Apr 7, 2025
| @@ -127,15 +131,16 @@ func TestCleanProjectAndClusters(t *testing.T) { | |||
| }) | |||
| } | |||
| t.Cleanup(func() { | |||
| projectsAfter := readAllProjects(t.Context(), t, client) | |||
| //nolint:usetesting // reason: using context.Background() here intentionally because t.Context() is canceled at cleanup | |||
There was a problem hiding this comment.
isn't there a way to avoid this linter exception?
lantoli
approved these changes
Apr 7, 2025
lantoli
reviewed
Apr 7, 2025
| @@ -40,6 +42,8 @@ var ( | |||
| "CANNOT_CLOSE_GROUP_ACTIVE_PEERING_CONNECTIONS", | |||
| "CANNOT_CLOSE_GROUP_ACTIVE_ATLAS_DATA_LAKES", | |||
| "CANNOT_CLOSE_GROUP_ACTIVE_ATLAS_DATA_FEDERATION_PRIVATE_ENDPOINTS", | |||
| "CANNOT_CLOSE_GROUP_ACTIVE_STREAMS_RESOURCE", | |||
| "CANNOT_CLOSE_GROUP_ACTIVE_ATLAS_PRIVATE_ENDPOINT_SERVICES", | |||
There was a problem hiding this comment.
can we maybe change the logic to detect if error has prefix CANNOT_CLOSE_GROUP_ACTIVE_ ?
There was a problem hiding this comment.
Prefer to keep as is for now & see how this works for next few days & if we encounter other issues/errors
lantoli
added a commit
that referenced
this pull request
Apr 8, 2025
* master: chore: Updates org_clean_test.go to delete stream instances & private endpoint services (#3252) chore: Updates organization.md `skip_default_alerts_settings` note format (#3246) doc: Update guidelines for external contributors to squash commits (#3243) chore: Updates CHANGELOG.md for #3199
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates org_clean_test.go to delete stream instances & private endpoint services
Test runs:
https://github.com/mongodb/terraform-provider-mongodbatlas/actions/runs/14273965328/job/40013230931
https://github.com/mongodb/terraform-provider-mongodbatlas/actions/runs/14274317052/job/40014298440
Type of change:
Required Checklist:
Further comments