Skip to content

Label filters in table toolbar should be wider like other label filters #1824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spadgett opened this issue Jul 11, 2017 · 3 comments
Closed
Assignees
Labels
area/styles kind/bug Categorizes issue or PR as related to a bug. priority/P3

Comments

@spadgett
Copy link
Member

These look like they're different types of filters, although they're really the same. I think part of it is that the widths are so different. We should have the table filter expand the to the same width.

openshift web console 2017-07-11 12-23-56

openshift web console 2017-07-11 12-22-55

@ncameronbritt

@spadgett spadgett added area/styles kind/bug Categorizes issue or PR as related to a bug. priority/P3 labels Jul 11, 2017
@ncameronbritt
Copy link

There's the width question, but there's also the question of whether the the filter should be part of the table. PF docs have both.
https://rawgit.com/patternfly/patternfly/master-dist/dist/tests/table-view-navbar.html
https://rawgit.com/patternfly/patternfly/master-dist/dist/tests/table-view.html

In the cases you're showing, it makes sense to me to have the filter as part of the table, since that's all the the filter is acting on. @openshift/team-ux-review what thoughts do you have?

@spadgett
Copy link
Member Author

In the cases you're showing, it makes sense to me to have the filter as part of the table, since that's all the the filter is acting on

+1, it would also be really odd to go to the events tab and see two filter controls, with only one of them working on the events

@spadgett
Copy link
Member Author

Related PR for events table filter styles: #1826

sg00dwin added a commit to sg00dwin/origin-web-console that referenced this issue Jul 12, 2017
sg00dwin added a commit to sg00dwin/origin-web-console that referenced this issue Jul 12, 2017
sg00dwin added a commit to sg00dwin/origin-web-console that referenced this issue Jul 12, 2017
f0x11 pushed a commit to f0x11/origin-web-console that referenced this issue Mar 26, 2018
f0x11 pushed a commit to f0x11/origin-web-console that referenced this issue Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/styles kind/bug Categorizes issue or PR as related to a bug. priority/P3
Projects
None yet
Development

No branches or pull requests

3 participants