-
Notifications
You must be signed in to change notification settings - Fork 232
Label filters in table toolbar should be wider like other label filters #1824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
There's the width question, but there's also the question of whether the the filter should be part of the table. PF docs have both. In the cases you're showing, it makes sense to me to have the filter as part of the table, since that's all the the filter is acting on. @openshift/team-ux-review what thoughts do you have? |
+1, it would also be really odd to go to the events tab and see two filter controls, with only one of them working on the events |
Related PR for events table filter styles: #1826 |
…nd extend on top of table Fixes openshift#1824
…nd extend on top of table Fixes openshift#1824
…nd extend on top of table Fixes openshift#1824
…nd extend on top of table Fixes openshift#1824
…nd extend on top of table Fixes openshift#1824
These look like they're different types of filters, although they're really the same. I think part of it is that the widths are so different. We should have the table filter expand the to the same width.
@ncameronbritt
The text was updated successfully, but these errors were encountered: