Update table label filter to reuse .data-toolbar .data-toolbar-filter and extend on top of table #1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will conflict with #1826 :/ |
|
I can rebase #1826 on this one. I think I can reuse the style. |
rhamilto
reviewed
Jul 12, 2017
dist/styles/vendor.css
Outdated
| @@ -178,7 +178,7 @@ kubernetes-container-terminal{position:relative;display:block} | |||
| kubernetes-container-terminal .terminal{font-family:"Monospace Regular","DejaVu Sans Mono",Menlo,Monaco,Consolas,monospace;font-size:10px;color:#F0F0F0;text-align:left;outline:0;background-color:#000;border:1px solid #000;padding:10px;display:inline-block;line-height:1em} | |||
| @media (min-width:568px){kubernetes-container-terminal .terminal{font-size:12px} | |||
| } | |||
| kubernetes-container-terminal .terminal-cursor{color:#000;background:#f0f0f0} | |||
| kubernetes-container-terminal .terminal-cursor{background:#f0f0f0;color:#000;position:absolute} | |||
There was a problem hiding this comment.
This is invalid. Make sure you update your dependencies and rebuild.
…nd extend on top of table Fixes openshift#1824
sg00dwin
force-pushed
the
table-label-filter-issue1824
branch
from
3059914 to
ddf4e78
Compare
|
@spadgett updated pr to remove inadvertent vendor changes |
|
[merge][severity: bug] |
|
Evaluated for origin web console merge up to ddf4e78 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/15/) (Base Commit: 4209f2a) (PR Branch Commit: ddf4e78) (Extended Tests: bug) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1824
tested on Chrome, Safari, Firefox, IE