Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use table toolbar styles for events filter #1826

Merged
merged 1 commit into from
Jul 26, 2017
Merged

Use table toolbar styles for events filter #1826

merged 1 commit into from
Jul 26, 2017

Conversation

spadgett
Copy link
Member

@spadgett spadgett requested a review from jwforres July 11, 2017 18:21
@spadgett
Copy link
Member Author

@openshift/team-ux-review

@spadgett spadgett mentioned this pull request Jul 11, 2017
Closed
jwforres
jwforres approved these changes Jul 11, 2017
View reviewed changes
Copy link
Member

@jwforres jwforres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM for 3.7 assuming UX review gives it the OK

@spadgett
Copy link
Member Author

The "before" screenshot:

openshift web console 2017-07-11 15-01-33

We're trying to make the events filter more consistent with this one:

openshift web console 2017-07-11 15-02-14

@spadgett spadgett mentioned this pull request Jul 12, 2017
Merged
@spadgett
Copy link
Member Author

We should merge #1836 first, and I'll rebase this PR.

@spadgett spadgett changed the title Use table toolar styles for events filter [WIP] Use table toolar styles for events filter Jul 12, 2017
@spadgett spadgett force-pushed the events-table-toolbar branch from 94c1cf5 to 1b0e539 Compare July 19, 2017 21:11
@spadgett spadgett changed the title [WIP] Use table toolar styles for events filter Use table toolbar styles for events filter Jul 19, 2017
@spadgett spadgett force-pushed the events-table-toolbar branch from 1b0e539 to 43dfda1 Compare July 19, 2017 21:12
@spadgett
Copy link
Member Author

Rebased and updated to use the styles from #1836

@spadgett
Copy link
Member Author

@openshift/team-ux-review Any objections?

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 20, 2017
@spadgett spadgett force-pushed the events-table-toolbar branch from 43dfda1 to e74ba9a Compare July 20, 2017 12:11
@spadgett
Copy link
Member Author

Rebased.

@openshift-bot openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 20, 2017
@spadgett
Copy link
Member Author

[merge]

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 25, 2017
@spadgett spadgett force-pushed the events-table-toolbar branch from e74ba9a to 425a623 Compare July 26, 2017 13:09
@spadgett spadgett removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 26, 2017
@openshift-bot
Copy link

Evaluated for origin web console merge up to 425a623

@openshift-bot
Copy link

openshift-bot commented Jul 26, 2017 •
edited
Loading

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/54/) (Base Commit: 19290de) (PR Branch Commit: 425a623)

@openshift-bot openshift-bot merged commit 441f98f into openshift:master Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwforres jwforres jwforres approved these changes

Assignees
No one assigned
Labels
area/styles area/usability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spadgett @openshift-bot @jwforres