Skip to content

Replace matplotlib seaborn style plots with Arviz Plots in Documentation #4563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Replace matplotlib seaborn style plots with Arviz Plots in Documentation #4563

merged 1 commit into from
Mar 24, 2021

Conversation

mjhajharia
Copy link
Member

While working on #3859 , we saw seaborn-darkgrid is not the best of color friendly styles, and seaborn-colorblind is not regularly updated. arviz-darkgrid is relatively better and additionally as @OriolAbril pointed out - matplotlib styles have not been updated in ~5 years, so using ArviZ would give us better control and the ability to easily update the style if needed.

This PR changes plt.style.use("seaborn-darkgrid") to arviz-darkgrid and adds a line of importing arviz, which is anyway a pymc3 dependency.

These changes are in continuous.py and discrete.py (i.e. The sample plots in documentation)

Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@mjhajharia mjhajharia changed the title Replace matplotlib seaborn style plots with Arviz Plots in Documentation (WIP) Replace matplotlib seaborn style plots with Arviz Plots in Documentation Mar 24, 2021
@mjhajharia mjhajharia marked this pull request as ready for review March 24, 2021 12:27
@mjhajharia
Copy link
Member Author

@canyon289 feel free to have a look anytime and merge if satisfactory.

@canyon289
Copy link
Member

Looks great. As a matter of proceedings I personally dont have to review ever PR here (thankfully)
What usually happens is one core contributor, like Oriol, will approve the changes and then another maintainer will take a quick glance and merge it usually within a couple of days and hopefully wont leave you waiting too long

@canyon289 canyon289 merged commit 97b54f0 into pymc-devs:master Mar 24, 2021
@mjhajharia
Copy link
Member Author

mjhajharia commented Mar 24, 2021 via email

sthagen added a commit to sthagen/pymc-devs-pymc that referenced this pull request Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants