error make initdb if xz isn't installed
#5872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This threw me for a loop getting warehouse setup on my new laptop! `make initdb` was silently failing.
|
@di I feel ok going ahead and merging this; how do you feel? |
|
I had talked to @ewdurbin elsewhere about moving this step into a container to sidestep this problem entirely. I think he was attempting to do that but probably got sidetracked by more important stuff. |
|
If this is a small positive step then how about we merge it and then work on the bigger improvement later? |
|
Sorry I didn't close the loop! Moving it into the docker container was non-trivial. Let's merge this up. Might make sense to look through all remaining local dev tasks and file an issue with a punch list to move them all into containers. This will likely make for a good contribution from someone with more docker-compose experience! |
miketheman
added a commit
to miketheman/warehouse
that referenced
this pull request
Mar 20, 2022
When moving all development actions to containers in pypi#10803, this step remained outside on the host OS. As `xz-utils` are installed in the `web` image already, use those instead of relying on the host to install them. Refs: pypi#5872 Closes: pypi#5980 Signed-off-by: Mike Fiedler <[email protected]>
di
pushed a commit
that referenced
this pull request
Mar 20, 2022
When moving all development actions to containers in #10803, this step remained outside on the host OS. As `xz-utils` are installed in the `web` image already, use those instead of relying on the host to install them. Refs: #5872 Closes: #5980 Signed-off-by: Mike Fiedler <[email protected]>
domdfcoding
pushed a commit
to domdfcoding/warehouse
that referenced
this pull request
Jun 7, 2022
When moving all development actions to containers in pypi#10803, this step remained outside on the host OS. As `xz-utils` are installed in the `web` image already, use those instead of relying on the host to install them. Refs: pypi#5872 Closes: pypi#5980 Signed-off-by: Mike Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This threw me for a loop getting warehouse setup on my new laptop!
make initdbwas silently failing to load the dev db assets.