-
Notifications
You must be signed in to change notification settings - Fork 1k
Error if no xz installed #5980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
trishankatdatadog
wants to merge
8
commits into
pypi:main
from
trishankatdatadog:trishankatdatadog/which-xz
Closed
Error if no xz installed #5980
trishankatdatadog
wants to merge
8
commits into
pypi:main
from
trishankatdatadog:trishankatdatadog/which-xz
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This still doesn't seem to work on latest MacOS... xz installed via Homebrew. ewd3imac:warehouse ewdurbin$ git diff
diff --git a/Makefile b/Makefile
index 480a9b72..dc1cdbd4 100644
--- a/Makefile
+++ b/Makefile
@@ -149,6 +149,7 @@ ifneq ($(PR), false)
endif
initdb:
+ xz -V &> /dev/null || $(error "No xz available on PATH, install xz!")
docker-compose run --rm web psql -h db -d postgres -U postgres -c "DROP DATABASE IF EXISTS warehouse"
docker-compose run --rm web psql -h db -d postgres -U postgres -c "CREATE DATABASE warehouse ENCODING 'UTF8'"
xz -d -f -k dev/$(DB).sql.xz --stdout | docker-compose run --rm web psql -h db -d warehouse -U postgres -v ON_ERROR_STOP=1 -1 -f -
ewd3imac:warehouse ewdurbin$ make initdb
Makefile:152: *** "No xz available on PATH, install xz!". Stop.
ewd3imac:warehouse ewdurbin$ xz -V
xz (XZ Utils) 5.2.4
liblzma 5.2.4
ewd3imac:warehouse ewdurbin$ which xz
/usr/local/bin/xz
ewd3imac:warehouse ewdurbin$ system_profiler SPSoftwareDataType
Software:
System Software Overview:
System Version: macOS 10.14.5 (18F132)
Kernel Version: Darwin 18.6.0
Boot Volume: ewd3mojave
Boot Mode: Normal
Computer Name: ewd3imac
User Name: Ernest W Durbin III (ewdurbin)
Secure Virtual Memory: Enabled
System Integrity Protection: Enabled
Time since boot: 13 days 53 minutes |
WFM... does anyone else want to try? |
@di could you give this a try? |
Merged
Looks like
@ewdurbin What do you think? |
FYI a |
miketheman
added a commit
to miketheman/warehouse
that referenced
this pull request
Mar 20, 2022
When moving all development actions to containers in pypi#10803, this step remained outside on the host OS. As `xz-utils` are installed in the `web` image already, use those instead of relying on the host to install them. Refs: pypi#5872 Closes: pypi#5980 Signed-off-by: Mike Fiedler <[email protected]>
di
pushed a commit
that referenced
this pull request
Mar 20, 2022
When moving all development actions to containers in #10803, this step remained outside on the host OS. As `xz-utils` are installed in the `web` image already, use those instead of relying on the host to install them. Refs: #5872 Closes: #5980 Signed-off-by: Mike Fiedler <[email protected]>
domdfcoding
pushed a commit
to domdfcoding/warehouse
that referenced
this pull request
Jun 7, 2022
When moving all development actions to containers in pypi#10803, this step remained outside on the host OS. As `xz-utils` are installed in the `web` image already, use those instead of relying on the host to install them. Refs: pypi#5872 Closes: pypi#5980 Signed-off-by: Mike Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix #5872