Merge master into features #3914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cache now obeys -q when showing summary for --lf and --ff
Improve the coverage of testing/code
pytest-dev#3888 (comment) closes pytest-dev#3888 Co-authored-by: Bruno Oliveira <[email protected]>
Fix bad console output when using console_output_style=classic
…write What happens is that atomic_write on Python 2.7 on Windows will try to convert the paths to unicode, but this triggers the import of the encoding module for the file system codec, which in turn triggers the rewrite, which in turn again tries to import the module, and so on. This short-circuits the cases where we try to import another file when writing a pyc file; I don't expect this to affect anything because the only modules that could be affected are those imported by atomic_writes. Fix pytest-dev#3506
travis: run tests on macOS
Travis: add baseline stage
Avoid possible infinite recursion when writing pyc files in assert rewrite
Fix pytest.org links
Preparing release version 3.7.4
- Skips pypy for coverage, reports only py37 to coveralls - tox: allow for TOXENV=py37-coverage - tracks coverage in subprocesses, using coverage-enable-subprocess, and parallel=1 - removes usedevelop with doctesting to match `--source` being used with coverage - keep coveralls for now, used with AppVeyor
doctesting: remove changedir With coverage 5 we could use COVERAGE_RCFILE to make it find the .coveragerc, or we could add `--rcfile` to _PYTEST_TOX_COVERAGE_RUN, but I've thought that this should not be the job that has to test if `--pyargs` actually works.
Given that our guidelines demand that the CI have already passed, it seems wasteful to run all those jobs again for the exact same commit. As discussed in pytest-dev#3906 (comment), this will skip the "test" stage when building a tag for deployment.
Update release procedure
Skip the "test" stage when making a release
Travis: report coverage with all builds
doc fix: raises accepts tuples instead of lists
|
looks like the tox setup is now broken |
|
@blueyed can you take a look, it seems related to that coverage hack not working as "expected" |
|
Actually this just seems like a conflicting test now that we merged #3912 into |
…ints_no_needless_message * test_lf_and_ff_obey_verbosity is no longer necessary because test_lf_and_ff_prints_no_needless_message already checks if the proper messages are displayed when -q is used. * Improve test_lf_and_ff_prints_no_needless_message so we also check that the correct message is displayed when there are failures to run
|
Should be working now. 👍 |
Codecov Report
@@ Coverage Diff @@
## features #3914 +/- ##
============================================
+ Coverage 92.2% 96.24% +4.03%
============================================
Files 52 108 +56
Lines 10016 23409 +13393
============================================
+ Hits 9235 22529 +13294
- Misses 781 880 +99
Continue to review full report at Codecov.
|
|
@nicoddemus : do I need to improve the tests there? is there any problem? |
RonnyPfannschmidt
approved these changes
Aug 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.