Skip to content

[3.14] GH-134774: fix 'Py_DEBUG': macro redefinition warnings for Windows debug builds #134790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 269 commits into from

Conversation

chris-eibl
Copy link
Member

@chris-eibl chris-eibl commented May 27, 2025

Since PR #134211 / issue #133779 was packported to 3.14, Windows debug builds show more than thousand such warnings:

pyconfig.h(390,16): warning C4005: 'Py_DEBUG': macro redefinition

This stems from

cpython/PC/pyconfig.h

Lines 97 to 100 in b6e624a

/* _DEBUG implies Py_DEBUG */
#ifdef _DEBUG
# define Py_DEBUG 1
#endif

which got added in the above PR, but rather belong to PR #131944 / issue #131942 and should just be deleted.


📚 Documentation preview 📚: https://cpython-previews--134790.org.readthedocs.build/

miss-islington and others added 30 commits May 8, 2025 11:36
…version_from_kernel32 (pythonGH-133598)

(cherry picked from commit 0ec8fc8)

Co-authored-by: Sergey Miryanov <[email protected]>
…mory as bigmem (pythonGH-133456) (pythonGH-133663)

(cherry picked from commit 26839ea)

Co-authored-by: Serhiy Storchaka <[email protected]>
…133635) (python#133666)

pythongh-133581: Improve AST unparsing of t-strings (pythonGH-133635)
(cherry picked from commit bfac7d2)

Co-authored-by: Jelle Zijlstra <[email protected]>
This converts functions, code, str, bytes, bytearray, and memoryview objects to PyCodeObject,
and ensure that the object looks like a script.  That means no args, no return, and no closure.
_PyCode_GetPureScriptXIData() takes it a step further and ensures there are no globals.

We also add _PyObject_SupportedAsScript() to the internal C-API.

(cherry picked from commit c81fa2b, AKA pythongh-133480)

Co-authored-by: Eric Snow <[email protected]>
…ds in socket module (pythonGH-133208) (python#133683)

pythongh-132886: use relaxed atomics for `sock_fd` in gil builds in socket module (pythonGH-133208)
(cherry picked from commit 2d82ab7)

Co-authored-by: Kumar Aditya <[email protected]>
…ythongh-133627) (pythongh-133685)

The function `dict_set_fromkeys()` adds elements of a set to an existing
dictionary. The size of the expanded dictionary was estimated with
`PySet_GET_SIZE(iterable)`, which did not take into account the size of the
existing dictionary.
(cherry picked from commit 421ba58)

Co-authored-by: Angela Liss <[email protected]>
…` with mypy (pythonGH-133453) (python#133689)

pythongh-133403: Check `Tools/build/verify_ensurepip_wheels.py` with mypy (pythonGH-133453)
(cherry picked from commit 5f3d3f2)

Co-authored-by: Flosckow <[email protected]>
Co-authored-by: Daniil Dumchenko <[email protected]>
Co-authored-by: sobolevn <[email protected]>
…H-133674) (python#133695)

pythongh-103092: Support subinterpreters in ``_zstd`` (pythonGH-133674)
(cherry picked from commit 6f6f48d)

Co-authored-by: Adam Turner <[email protected]>
…identally pick up site-packages (pythonGH-133693)

(cherry picked from commit 6ce469d)

Co-authored-by: Steve Dower <[email protected]>
…thonGH-133544) (pythongh-133718)

On Linux, use /proc/self/status for mem usage info.  Using smaps_rollup is quite a lot slower and
we can get the similar info from /proc/self/status.
(cherry picked from commit 751db4e)

Co-authored-by: Neil Schemenauer <[email protected]>
…character entities in attribute values (pythonGH-95215) (pythonGH-133704)

According to the HTML5 spec, named character references in attribute values
should only be processed if they are not followed by an ASCII alphanumeric,
or an equals sign.
(cherry picked from commit 77b14a6)


https: //html.spec.whatwg.org/multipage/parsing.html#named-character-reference-state

Co-authored-by: Sascha Ißbrücker <[email protected]>
…H-133708) (python#133729)

pythongh-133412: amend docs for the `inst` definition (pythonGH-133708)

The `stack_effect` is incorrectly documented as being allowed to be optional.
(cherry picked from commit f77dac6)

Co-authored-by: Nybblista <[email protected]>
…taken for multi-line sqlite statements in the sqlite3 command-line interface (pythonGH-133440) (pythonGH-133738)

(cherry picked from commit ebd4881)

Co-authored-by: Tan Long <[email protected]>
pythonGH-133749) (python#133751)

pythongh-133644: update `Py_InteractiveFlag` deprecation notice (pythonGH-133749)
(cherry picked from commit 3ed8d6f)

Co-authored-by: Bénédikt Tran <[email protected]>
…b test (pythonGH-133702) (python#133754)

pythongh-133682: Fix inconsistent set ordering in annotationlib test (pythonGH-133702)
(cherry picked from commit a2a0fa9)

Co-authored-by: Akshat Gupta <[email protected]>
…ythonGH-133694) (python#133762)

pythonGH-132983: Remove subclassing support from zstd types (pythonGH-133694)

For consistency with ``bz2``, ``lzma``, and ``zlib``.
(cherry picked from commit bd7c585)

Co-authored-by: Adam Turner <[email protected]>
… with mypy (pythonGH-133735) (python#133764)

pythongh-133403: Check `Tools/build/generate-build-details.py` with mypy (pythonGH-133735)
(cherry picked from commit cd2f234)

Co-authored-by: sobolevn <[email protected]>
…thon#133756)

pythongh-132983: Clean-ups for ``_zstd`` (pythonGH-133670)
(cherry picked from commit c2a5d4b)

Co-authored-by: Adam Turner <[email protected]>
…133565) (python#133757)

pythonGH-132983: Restore libzstd fallback detection (pythonGH-133565)
(cherry picked from commit 2c7cac4)

Co-authored-by: Adam Turner <[email protected]>
…133270) (python#133769)

pythongh-46236: Document PyUnicode_BuildEncodingMap (pythonGH-133270)
(cherry picked from commit f34ec09)

Co-authored-by: Stan Ulbrych <[email protected]>
…onGH-133766) (python#133774)

pythongh-133741: Fix _can_strace(): check --trace option (pythonGH-133766)

The --trace option needs strace 5.5 or newer.
(cherry picked from commit 6708628)

Co-authored-by: Victor Stinner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants