Explore type based autocomplete #493
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| type someVariant = One | Two | Three | Four | ||
|
|
||
| let someVariantToString = (~someVariant) => | ||
| switch someVariant { | ||
| | One => "One" | ||
| | Two => "Two" | ||
| | Three => "Three" | ||
| | Four => "Four" | ||
| } | ||
|
|
||
| module SomeComponent = { | ||
| @react.component | ||
| let make = (~whatever) => { | ||
| someVariantToString(~someVariant=whatever)->React.string | ||
| } | ||
| } | ||
|
|
||
| // let x = someVariantToString(~someVaria | ||
| // ^com | ||
|
|
||
| // let x = someVariantToString(~someVariant= | ||
| // ^com | ||
|
|
||
| // let x = someVariantToString(~someVariant= | ||
| // ^com | ||
|
|
||
| // let x = someVariantToString(~someVariant=T | ||
| // ^com | ||
|
|
||
| // let x = someVariantToString(~someVariant=t | ||
| // ^com | ||
|
|
||
| // let jsx = <SomeComponent whatever= | ||
| // ^com |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| DCE src/Dce.res | ||
| issues:241 | ||
|
There was a problem hiding this comment. I should get rid of these differences. This is testing several things at once and it's not necessary. |
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| Complete src/TypeContextCompletion.res 17:41 | ||
| posCursor:[17:41] posNoWhite:[17:40] Found expr:[17:11->17:41] | ||
| Pexp_apply ...[17:11->17:30] (~someVaria17:32->17:41=...[17:32->17:41]) | ||
| Completable: CnamedArg(Value[someVariantToString], someVaria, [someVaria]) | ||
| Found type for function (~someVariant: someVariant) => string | ||
|
There was a problem hiding this comment. Need to check where this is coming from: presumably named arg completion finding the type of the function. |
||
| [{ | ||
| "label": "someVariant", | ||
| "kind": 4, | ||
| "tags": [], | ||
| "detail": "someVariant", | ||
| "documentation": null | ||
| }] | ||
|
|
||
| Complete src/TypeContextCompletion.res 20:44 | ||
| posCursor:[20:44] posNoWhite:[20:43] Found expr:[20:11->20:44] | ||
| Pexp_apply ...[20:11->20:30] (~someVariant20:32->20:43=...__ghost__[0:-1->0:-1]) | ||
| found typed context | ||
| Completable: CtypedContext(Value[someVariantToString]) | ||
| [] | ||
|
|
||
| Complete src/TypeContextCompletion.res 23:45 | ||
| posCursor:[23:45] posNoWhite:[23:43] Found expr:[23:11->23:44] | ||
| Pexp_apply ...[23:11->23:30] (~someVariant23:32->23:43=...__ghost__[0:-1->0:-1]) | ||
| found typed context | ||
| Completable: CtypedContext(Value[someVariantToString]) | ||
| [] | ||
|
|
||
| Complete src/TypeContextCompletion.res 26:45 | ||
| posCursor:[26:45] posNoWhite:[26:44] Found expr:[26:11->26:45] | ||
| Pexp_apply ...[26:11->26:30] (~someVariant26:32->26:43=...[26:44->26:45]) | ||
| found typed context | ||
| Completable: CtypedContext(Value[someVariantToString]) | ||
| [] | ||
|
|
||
| Complete src/TypeContextCompletion.res 29:45 | ||
| posCursor:[29:45] posNoWhite:[29:44] Found expr:[29:11->29:45] | ||
| Pexp_apply ...[29:11->29:30] (~someVariant29:32->29:43=...[29:44->29:45]) | ||
| found typed context | ||
| Completable: CtypedContext(Value[someVariantToString]) | ||
| [] | ||
|
There was a problem hiding this comment. As predicted, no result. |
||
|
|
||
| Complete src/TypeContextCompletion.res 32:37 | ||
| posCursor:[32:37] posNoWhite:[32:36] Found expr:[32:14->32:37] | ||
| JSX <SomeComponent:[32:14->32:27] whatever[32:28->32:36]=...__ghost__[0:-1->0:-1]> _children:None | ||
| [] | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you start adding comments to Cpath and contextPath?
There's the question of whether there should be an entirely different case of type t, or whether typed context info should be integrated into the existing ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind helping me out with adding comments to those that exist already? I have a hard time parsing what they are/mean.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cpathis for complex expressionsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CPStringis for string constants, used in pipe expressions34 -> ...CPArrayis for arrays used in pipe expressions[] -> ....CPApply of contextPath * Asttypes.arg_label listis application with a list of labelsCPId of string list * completionContextis for a pathA.orA.B.C.and the rhs is the rest to be completedCPField of contextPath * stringis the.zof record accessexpr.zCPObj of contextPath * stringis the["hello"]of object accessexpr["hello"]CPPipe of contextPath * stringisexpr->foowherefoois the function whose first argument isexpr.