CommandExt::before_exec: deprecate safety in edition 2024 #125970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Nilstrieb rustbot has assigned @Nilstrieb. Use |
rustbot
added
O-unix
|
The doc comment needs to be adjusted. It's confusing at the moment since |
|
r? libs-api |
rustbot
added
the
T-libs-api
|
Needs a test. I'm not sure if this works since this isn't a free standing function. |
|
@rustbot labels +I-libs-api-nominated Nominating for libs-api to decide whether to make calls to If we decide to do this, we'll use that same tracking issue: |
rustbot
added
the
I-libs-api-nominated
5 tasks
|
I extended the comment and added a test. It seems to be working fine. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
rfcbot
added
proposed-final-comment-period
This comment was marked as outdated.
This comment was marked as outdated.
joshtriplett
removed
the
T-libs
This comment was marked as outdated.
This comment was marked as outdated.
rfcbot
removed
proposed-final-comment-period
|
This function directly has a comment saying that it should be unsafe, and now we have a way to do that. @rfcbot merge |
|
Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
tbu-
added a commit
to tbu-/rust
that referenced
this pull request
Jul 17, 2024
Relevant for the deprecation of `CommandExt::before_exit` in rust-lang#125970.
tbu-
added a commit
to tbu-/rust
that referenced
this pull request
Jul 17, 2024
Relevant for the deprecation of `CommandExt::before_exit` in rust-lang#125970.
tbu-
added a commit
to tbu-/rust
that referenced
this pull request
Jul 17, 2024
Relevant for the deprecation of `CommandExt::before_exit` in rust-lang#125970.
rusty-snake
reviewed
Jul 28, 2024
tbu-
added a commit
to tbu-/rust
that referenced
this pull request
Jul 29, 2024
Relevant for the deprecation of `CommandExt::before_exit` in rust-lang#125970.
tbu-
added a commit
to tbu-/rust
that referenced
this pull request
Aug 8, 2024
Relevant for the deprecation of `CommandExt::before_exit` in rust-lang#125970.
tbu-
added a commit
to tbu-/rust
that referenced
this pull request
Aug 13, 2024
Relevant for the deprecation of `CommandExt::before_exit` in rust-lang#125970.
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 13, 2024
…trochenkov Allow to customize `// TODO:` comment for deprecated safe autofix Relevant for the deprecation of `CommandExt::before_exit` in rust-lang#125970. Tracking: - rust-lang#124866
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 13, 2024
…trochenkov Allow to customize `// TODO:` comment for deprecated safe autofix Relevant for the deprecation of `CommandExt::before_exit` in rust-lang#125970. Tracking: - rust-lang#124866
rustbot
removed
the
S-blocked
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 14, 2024
Rollup merge of rust-lang#127857 - tbu-:pr_deprecated_safe_todo, r=petrochenkov Allow to customize `// TODO:` comment for deprecated safe autofix Relevant for the deprecation of `CommandExt::before_exit` in rust-lang#125970. Tracking: - rust-lang#124866
|
@m-ou-se I rebased, so this should be ready for review now. :) |
tbu-
reviewed
Aug 14, 2024
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 14, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#125970 (CommandExt::before_exec: deprecate safety in edition 2024) - rust-lang#127905 (Add powerpc-unknown-linux-muslspe compile target) - rust-lang#128925 (derive(SmartPointer): register helper attributes) - rust-lang#128946 (Hash Ipv*Addr as an integer) - rust-lang#128963 (Add possibility to generate rustdoc JSON output to stdout) - rust-lang#129015 (Update books) - rust-lang#129067 (Use `append` instead of `extend(drain(..))`) - rust-lang#129100 (Fix dependencies cron job) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 15, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#125970 (CommandExt::before_exec: deprecate safety in edition 2024) - rust-lang#127905 (Add powerpc-unknown-linux-muslspe compile target) - rust-lang#128925 (derive(SmartPointer): register helper attributes) - rust-lang#128946 (Hash Ipv*Addr as an integer) - rust-lang#128963 (Add possibility to generate rustdoc JSON output to stdout) - rust-lang#129015 (Update books) - rust-lang#129067 (Use `append` instead of `extend(drain(..))`) - rust-lang#129100 (Fix dependencies cron job) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 15, 2024
Rollup merge of rust-lang#125970 - RalfJung:before_exec, r=m-ou-se CommandExt::before_exec: deprecate safety in edition 2024 Similar to `set_var`, we had to find out after 1.0 was released that `before_exec` should have been unsafe. We partially rectified this by deprecating that function a long time ago, but since rust-lang#124636 we have the ability to also deprecate the safety of the old function and make it a *hard error* to call the old function outside `unsafe` in the next edition. So just in case anyone still uses the old function, let's ensure this can't be ignored when moving code to the new edition. Cc `@rust-lang/libs-api` Tracking: - rust-lang#124866
Urgau
added
the
relnotes
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to
set_var, we had to find out after 1.0 was released thatbefore_execshould have been unsafe. We partially rectified this by deprecating that function a long time ago, but since #124636 we have the ability to also deprecate the safety of the old function and make it a hard error to call the old function outsideunsafein the next edition. So just in case anyone still uses the old function, let's ensure this can't be ignored when moving code to the new edition.Cc @rust-lang/libs-api
Tracking:
std::env::{set_var, remove_var}unsafe #124866