Handle measureme panics, and don't crash the collector on self-profile data errors #2016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this avoids crashing the collector and acts as if we had no data, which is not incorrect
| let res = | ||
| std::panic::catch_unwind(|| analyzeme::ProfilingData::from_paged_buffer(data, None)); | ||
| let results = match res { | ||
| Ok(Ok(profiling_data)) => profiling_data.perform_analysis(), |
There was a problem hiding this comment.
Does this also need to be in the catch_unwind?
There was a problem hiding this comment.
My understanding was that from the buffers being read (+ validation), then the data should be in a better shape, but I don't know for sure. I haven't checked deeply into the entire call stack there as the panics were really at the start of the entire process, but there are no obvious unwraps in this method at least.
Mark-Simulacrum
approved these changes
Nov 28, 2024
|
And we should be able to remove the catch_unwind when rust-lang/measureme#239 is merged, a release is published and we update the collector to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Situation: rustc creates invalid
-Zself-profiledata, the collector tries to read it and measureme crashes or returns an error => the collector panics (likely after 5 tries). On panics, the perf run is incomplete and the collector will try to complete it, which will still crash. This happened today in this run.This PR:
In the future we'll need to do another pass at error-handling and tightening up these cases. We'd ideally record any such issue as a benchmark failure, and move on to the other benchmarks.
This should do until then, I think.