Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to go modules and upgrade bblfsh client version #847

Merged
merged 9 commits into from
Jun 12, 2019

Conversation

erizocosmico
Copy link
Contributor

@erizocosmico erizocosmico commented May 31, 2019

Closes #838
Fixes #852
Fixes #846

Updated rev-upgrade tool to work with go modules.
Upgraded go-mysql-server that does not use gopkg-in anymore.
Upgraded bblfsh client to use the new one that uses go modules.

  • I updated the documentation explaining the new behavior if any.
  • I updated CHANGELOG.md file adding the new feature or bug fix.
  • I updated go-mysql-server using make upgrade command if applicable.
  • I added or updated examples if applicable.
  • I checked that changes on schema are reflected into the documentation, if applicable.

@erizocosmico erizocosmico requested a review from a team May 31, 2019 12:20
Copy link
Contributor

@kuba-- kuba-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if there is any other option than blindly accept it ;)

@kuba--
Copy link
Contributor

kuba-- commented May 31, 2019

Fix tests

fixtures folder not found

@erizocosmico
Copy link
Contributor Author

Ugh, yes. It happened to me locally, then it didn't anymore and forgot about that. go-git-fixtures does not work with go modules * sobs in spanish *

@juanjux
Copy link
Contributor

juanjux commented May 31, 2019

I trust @erizocosmico and his sed-foo prowess completely so I hereby approve the five thousand files of changes.

@erizocosmico erizocosmico force-pushed the feature/go-modules branch 3 times, most recently from 1ace7fc to 1711a5c Compare June 3, 2019 06:58
@erizocosmico
Copy link
Contributor Author

Waiting for a PR to be merged on go-git-fixtures before updating here and make tests work.

@ajnavarro
Copy link
Contributor

@erizocosmico go-git-fixtures is already merged, shall we continue with this?

@erizocosmico
Copy link
Contributor Author

Updated

@ajnavarro ajnavarro mentioned this pull request Jun 11, 2019
5 tasks
@erizocosmico
Copy link
Contributor Author

All fixed. Ready to be merged

@ajnavarro ajnavarro merged commit ca216b3 into src-d:master Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants