Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS cleanup #145

Closed
wants to merge 4 commits into from
Closed

CSS cleanup #145

wants to merge 4 commits into from

Conversation

mrmrs
Copy link

@mrmrs mrmrs commented Dec 4, 2015

Small fixes to the CSS.

  • Makes formatting of the file consistent
  • Removes unnecessary code
  • Corrects some simple syntax errors

mrmrs added 4 commits December 4, 2015 12:35
This changes all classes to be formatted in the same way.
* Each property is on it's own line
* Each declaration is on it's own line
* Single linebreak in between rulesets
* Remove quotes from url function
* Change background to background-image where only image is defined
Quotes in font-family value are not supposed to wrap around multiple
typeface names. They are only to wrap around single typeface names.
* Remove trailing and leading 0's from values with a decimal
* Remove commented out css
* Remove units from values of 0
.body {
color: black;
background: white;
margin: 0 0 0 0;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe replace this with margin: 0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

That'd be better.

@chrislloyd
Copy link

👍 on @mrmrs' changes. @philipgiuliani your comments warrant discussion but aren't useful in the context of these changes. Perhaps open another PR if you'd like to collapse CSS rules?

@CodaFi
Copy link
Contributor

CodaFi commented Jul 7, 2016

This issue is now resolved by the merge of #3368. Thank you @mrmrs for your contribution, and thank you to everybody else here for the discussion.

CodaFi added a commit that referenced this pull request Jul 7, 2016
[Gardening] Apply formatting rules from #145 to docs
@CodaFi CodaFi closed this Jul 7, 2016
slavapestov pushed a commit to slavapestov/swift that referenced this pull request Nov 27, 2018
…port-134-135-139-138-140

Backport PRs 134 135 139 138 140 to swift-3.0-branch
maldahleh pushed a commit to maldahleh/swift that referenced this pull request Oct 26, 2020
maldahleh pushed a commit to maldahleh/swift that referenced this pull request Oct 26, 2020
…sociatedtype"

This reverts commit 5bfc40b, reversing
changes made to adc26e4.
freak4pc pushed a commit to freak4pc/swift that referenced this pull request Sep 28, 2022
Adding config for Swift 4 support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants