Merge tag 'swift-DEVELOPMENT-SNAPSHOT-2019-12-16-a ' into tensorflow #28847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can retrieve it from the passed OverloadChoice.
This helps avoid confusion with SelectedOverload's `openedType` member.
Rather than passing separate parameters for the choice, openedType, and openedFullType, just pass the selected overload.
…l LiveRange class. In a forthcoming commit, I am going to need access to the "escaping" uses of a dead live range. Rather than add /another/ argument to isDeadLiveRange, this commit refactors the code to be a constructor on a general LiveRange class that internally contains the lists of destroys, forwarding instructions we can convert to be guaranteed, and consuming instructions that we do not understand. Should be NFC.
The extensions for supporting NSObjects are in the file: OSLogNSObjectType.swift. This creates a new dependency for the OSLogPrototype overlay on the module: ObjectiveC. However, ObjectiveC is already a dependency for the os module. This patch includes tests for the NSObject extensions. In addition, this patch contains a few other minor changes. 1. It makes the `osLog` function public (so that it can be used by clients directly). 2. It fixes a lifetime-related bug in the osLog function implementation. 3. It improves the OSLogPrototypeExecTest suite by refactoring a few helper functions.
[stdlib][Part 1] De-gyb almost everything
- Move `DifferentiableAttr` definition above `DeclAttributes` in include/swift/AST/Attr.h, like other attributes. - Remove unnecessary arguments from `DifferentiableAttr::DifferentiableAttr` and `DifferentiableAttr::setDerivativeGenericSignature`. - Add libSyntax test for `@differentiable` attributes.
autolink-extract is needed on ELF (and windows-cygnus). However, WASM also has gone down this path and did not actually indicate that it needed the autolink extract handling. Extract the handling check into a variable which helps readability.
…4f321977df32bf [semantic-arc-opts] Convert isDeadLiveRange into a method on a general LiveRange class.
IRGen,Driver: extract tool usage into a variable (NFC)
[NFC] Pull Semantic Member Synthesis into TypeChecker's Lookup Entrypoints
Update CHANGELOG for SR-11841 fix
[CS] Pass SelectedOverload in a couple of places
…eC return a valid SILDeclRef rdar://57757241
[os log][stdlib/private] Add extensions for logging NSObjects.
Bump runtime to load backward compatibility hacks from __swift52_hooks
To implement swift_errorBridgingInfo, the Foundation overlay needs to import private runtime headers. Now that we cannot statically link the Foundation overlay, there is no point to keeping this workaround in the overlay any more. This effectively reverts #16677. rdar://problem/57809306
`TensorFlow` is no longer tested in this repository.
|
@swift-ci Please clean test tensorflow |
|
@swift-ci Please clean test tensorflow |
|
Thanks! Should we squash the additional commits into the merge? I can try this myself. |
asuhan
approved these changes
Dec 18, 2019
Sure, if you'd like to! I don't feel strongly. |
|
Squashing the additional commits is a pain, we'll go ahead as-is. |
|
@swift-ci Please clean test tensorflow |
This was referenced Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.