toolchain: Add Espressif's ESP32 and ESP32S2 support #426

sylvioalves · 2022-02-17T20:47:29Z

No description provided.

sylvioalves · 2022-02-18T02:00:27Z

@galak, not sure if the buildkite error is indeed an error. Would you check?

stephanosio · 2022-02-18T02:06:03Z

@galak, not sure if the buildkite error is indeed an error. Would you check?

@sylvioalves I have re-triggered the CI. It should succeed.

stephanosio

@sylvioalves Have you verified that this works with the ESP32? IIRC, there were some issues earlier without applying the ESP32-specific patches for gcc, newlib and others.

sylvioalves · 2022-02-18T02:19:58Z

@stephanosio @galak We analyzed all the patches in Espressif's gcc/gdb/newlib repository and concluded that we can have it as is (without patches). We will submit some patches upstream eventually, but there is no blocking patch at all to have it integrated in Zephyr.
However, this won't work in Zephyr with latest branch, of course. I will submit a PR with a bunch of changes to enable the usage of this new toolchain. Can you suggest me a way to synchronize this?
Also, I have build this toolchain locally, copied and pasted into the zephyr's sdk folder to simulate final behavior. Works good. Let me know if you want any sort of testing or info, ok?

stephanosio · 2022-02-18T07:57:30Z

However, this won't work in Zephyr with latest branch, of course.

Do you mean the "ESP32 toolchain" built using the changes in this PR is not able to build working binaries for the ESP32 SoC? If so, this PR should be considered a draft until it can.

Can you suggest me a way to synchronize this?

If you have ESP32-specific patches for the binutils, gcc and newlib, please create a pull request in the relevant Zephyr fork repositories and update this PR to reference them (you can set *_DEVEL_REVISION to pull/(PR NUMBER)/head).

For example, if you have a patch for gcc:

Create a pull request to the zephyr-gcc-10.3.0 branch in the Zephyr gcc repository. Let's say this PR is number 10.
Set CT_GCC_DEVEL_REVISION="pull/10/head" in the toolchain config files in this PR, and push to build the toolchain.
Test the toolchain.
Merge the GCC PR.
Set CT_GCC_DEVEL_REVISION="(MERGED COMMIT SHA)" in the toolchain config files.
Merge this PR.

sylvioalves · 2022-02-18T11:23:26Z

@stephanosio Yes, current Zephyr's main branch can't be build using the toolchain from this PR. I am working out a Zephyr's PR to enabled this (I have it all working locally already).
Regarding patches, I won't submit any patch at all as it works as is.

stephanosio

Please specify the source (URL) and version of the xtensa_espressif_esp32.tar.gz and xtensa_espressif_esp32s2.tar.gz added here in the commit message.

.github/workflows/ci.yml

stephanosio · 2022-03-08T18:13:46Z

Also noting that this needs to be tested against zephyrproject-rtos/zephyr#43534.

sylvioalves · 2022-03-08T19:32:32Z

Please specify the source (URL) and version of the xtensa_espressif_esp32.tar.gz and xtensa_espressif_esp32s2.tar.gz added here in the commit message.

I added the github URL in the commit message. The .tar.gz file was manually created.

stephanosio · 2022-03-09T06:16:10Z

I added the github URL in the commit message.

@sylvioalves Thanks. Please add the version/tag or commit (in xtensa-overlay repository) from which the tarball was created in the commit message as well. This will make identifying the current version of overlays we have in the sdk-ng repository much easier, in case we ever need to update these overlays in the future.

stephanosio

Looks ok overall.

DNM until the build failures described in zephyrproject-rtos/zephyr#43534 (review) are resolved, in case they require Zephyr SDK-side changes.

stephanosio · 2022-03-11T11:22:43Z

Postponing this to 0.14.1, which will be a quick follow-up to 0.14.0 (multi-platform SDK) in a month or so.

sylvioalves · 2022-03-11T18:10:46Z

Only added commit sha into commit message.

stephanosio

There has been a slight change to the way the toolchain components are referenced in the configs (#444).

Could you update the PR as follows?

configs/xtensa-espressif_esp32_zephyr-elf.config

configs/xtensa-espressif_esp32s2_zephyr-elf.config

stephanosio

Thanks for the update. It looks like the GDB source configs were duplicated in the xtensa-espressif_esp32_zephyr-elf.config (specified GDB instead of Binutils at the top).

Also I found a few extra changes to be made; it would be good to address them while we are at it.

configs/xtensa-espressif_esp32_zephyr-elf.config

configs/xtensa-espressif_esp32s2_zephyr-elf.config

configs/xtensa-espressif_esp32_zephyr-elf.config

configs/xtensa-espressif_esp32s2_zephyr-elf.config

sylvioalves · 2022-03-21T11:32:59Z

Thanks for the update. It looks like the GDB source configs were duplicated in the xtensa-espressif_esp32_zephyr-elf.config (specified GDB instead of Binutils at the top).

Also I found a few extra changes to be made; it would be good to address them while we are at it.

Thanks for pointing that out.

Add all necessary changes to allow ESP32 toolchain integration. Overlay URL: https://github.com/espressif/xtensa-overlays/tree/master/xtensa_esp32 commit: 30d30463d2bd917d2c504122a887aff00b27f858 Signed-off-by: Sylvio Alves <[email protected]>

Add all necessary changes to allow ESP32S2 toolchain integration. Overlay URL: https://github.com/espressif/xtensa-overlays/tree/master/xtensa_esp32s2 commit: ac00ec5abf21102578d9afde22ffffd46929feaf Signed-off-by: Sylvio Alves <[email protected]>

Add CI content. Signed-off-by: Sylvio Alves <[email protected]>

stephanosio

Looks ok overall.

Pending tests.

stephanosio · 2022-03-21T17:38:58Z

Ran full twister build on the esp32 and esp32s2_saola boards with zephyrproject-rtos/zephyr@6e952a0 (#43534), verified that all test builds succeed (build only, no hardware runs).

sylvioalves requested review from galak, dcpleung and stephanosio February 17, 2022 20:47

sylvioalves changed the title ~~toolchain: Add Espressif ESP32 and ESP32S2 support~~ toolchain: Add Espressif's ESP32 and ESP32S2 support Feb 17, 2022

stephanosio reviewed Feb 18, 2022

View reviewed changes

stephanosio marked this pull request as draft February 18, 2022 08:04

stephanosio added the area: Toolchain Issues related to Toolchain (Binutils+GCC+GDB+libs) label Feb 22, 2022

sylvioalves mentioned this pull request Mar 8, 2022

soc: esp32: add support to zephyr-sdk, newlibc and cpp zephyrproject-rtos/zephyr#43534

Merged

sylvioalves force-pushed the feature/espressif_toolchain branch 4 times, most recently from 3ea778e to 595d052 Compare March 8, 2022 15:22

stephanosio requested changes Mar 8, 2022

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

.github/workflows/ci.yml Outdated Show resolved Hide resolved

sylvioalves force-pushed the feature/espressif_toolchain branch 2 times, most recently from 89756fb to 8769867 Compare March 8, 2022 19:37

stephanosio added this to the 0.14.0 milestone Mar 9, 2022

stephanosio added the DNM DO NOT MERGE label Mar 9, 2022

stephanosio reviewed Mar 9, 2022

View reviewed changes

stephanosio modified the milestones: 0.14.0, 0.14.1 Mar 11, 2022

sylvioalves force-pushed the feature/espressif_toolchain branch from 8769867 to 7e60eb9 Compare March 11, 2022 18:10

This was referenced Mar 17, 2022

Test & update to use new Zephyr toolchain golioth/golioth-zephyr-sdk#179

Closed

Update documentation to use the new Zephyr toolchain golioth/docs#172

Closed

stephanosio requested changes Mar 20, 2022

View reviewed changes

sylvioalves force-pushed the feature/espressif_toolchain branch from 7e60eb9 to 19948b1 Compare March 20, 2022 18:19

sylvioalves requested a review from stephanosio March 21, 2022 04:21

stephanosio requested changes Mar 21, 2022

View reviewed changes

sylvioalves force-pushed the feature/espressif_toolchain branch 2 times, most recently from 77ed6b0 to a626957 Compare March 21, 2022 11:35

sylvioalves added 3 commits March 21, 2022 08:36

ci: add Espressif ESP32 and ESP32S2

714cc8b

Add CI content. Signed-off-by: Sylvio Alves <[email protected]>

sylvioalves force-pushed the feature/espressif_toolchain branch from a626957 to 714cc8b Compare March 21, 2022 11:36

sylvioalves marked this pull request as ready for review March 21, 2022 11:37

stephanosio approved these changes Mar 21, 2022

View reviewed changes

stephanosio removed the DNM DO NOT MERGE label Mar 21, 2022

stephanosio merged commit 798295a into zephyrproject-rtos:main Mar 21, 2022

stephanosio mentioned this pull request Mar 24, 2022

GNU Arm Embedded toolchain deprecation zephyrproject-rtos/zephyr#43843

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

toolchain: Add Espressif's ESP32 and ESP32S2 support #426

toolchain: Add Espressif's ESP32 and ESP32S2 support #426

sylvioalves commented Feb 17, 2022

sylvioalves commented Feb 18, 2022

stephanosio commented Feb 18, 2022

stephanosio left a comment

sylvioalves commented Feb 18, 2022 •

edited

Loading

stephanosio commented Feb 18, 2022 •

edited

Loading

sylvioalves commented Feb 18, 2022 •

edited

Loading

stephanosio left a comment

stephanosio commented Mar 8, 2022

sylvioalves commented Mar 8, 2022

stephanosio commented Mar 9, 2022

stephanosio left a comment

stephanosio commented Mar 11, 2022

sylvioalves commented Mar 11, 2022

stephanosio left a comment

stephanosio left a comment

sylvioalves commented Mar 21, 2022

stephanosio left a comment

stephanosio commented Mar 21, 2022

toolchain: Add Espressif's ESP32 and ESP32S2 support #426

toolchain: Add Espressif's ESP32 and ESP32S2 support #426

Conversation

sylvioalves commented Feb 17, 2022

sylvioalves commented Feb 18, 2022

stephanosio commented Feb 18, 2022

stephanosio left a comment

Choose a reason for hiding this comment

sylvioalves commented Feb 18, 2022 • edited Loading

stephanosio commented Feb 18, 2022 • edited Loading

sylvioalves commented Feb 18, 2022 • edited Loading

stephanosio left a comment

Choose a reason for hiding this comment

stephanosio commented Mar 8, 2022

sylvioalves commented Mar 8, 2022

stephanosio commented Mar 9, 2022

stephanosio left a comment

Choose a reason for hiding this comment

stephanosio commented Mar 11, 2022

sylvioalves commented Mar 11, 2022

stephanosio left a comment

Choose a reason for hiding this comment

stephanosio left a comment

Choose a reason for hiding this comment

sylvioalves commented Mar 21, 2022

stephanosio left a comment

Choose a reason for hiding this comment

stephanosio commented Mar 21, 2022

sylvioalves commented Feb 18, 2022 •

edited

Loading

stephanosio commented Feb 18, 2022 •

edited

Loading

sylvioalves commented Feb 18, 2022 •

edited

Loading