boards: arm: add support for stm32f072b_disco board #5405

dwagenk · 2017-12-15T08:21:09Z

No description provided.

dwagenk · 2017-12-15T09:21:49Z

shippable returns unstable with linking errors in some tests (e.g. tests/net/ieee802154/l2/test, tests/net/lib/mqtt_subscriber/test), because of small SRAM. I expected
ram: 16
at stm32f072b_disco.yaml to prevent the tests beeing run for this target.

How should this be solved?

galak · 2017-12-15T12:34:54Z

shippable returns unstable with linking errors in some tests (e.g. tests/net/ieee802154/l2/test, tests/net/lib/mqtt_subscriber/test), because of small SRAM. I expected
ram: 16
at stm32f072b_disco.yaml to prevent the tests beeing run for this target.

How should this be solved?

For most of the smaller ram boards we've done something like the following in BOARD.yaml

testing:
  ignore_tags:
    - net
    - bluetooth

See boards/arm/frdm_kl25z/frdm_kl25z.yaml as an example

dbkinder

One formatting issues

dbkinder · 2017-12-15T20:27:06Z

boards/arm/stm32f072b_disco/doc/stm32f072b_disco.rst

+
+- Six LEDs:
+
+       - LD1 (red/green) for USB communication


This sublist looks better when it's not indented so much, 4 spaces is sufficient. Otherwise the html that's generated has a vertical bar added on the left because it looks like a quoted text block.

actually I had to go down to 2 Spaces to remove the quote-bar.

dwagenk · 2017-12-19T08:31:46Z

fixup:
I missed, that doc and pinmux.c were out of sync.
Added I2C_1 to pinmux.c and removed I2C_2 from doc.

erwango

SoC STM32F072xB is being introduced as part of #5171 which should be close to merge.
I think you should wait it is merged and rebase on top of it.
Otherwise LGTM

superna9999 · 2017-12-21T15:35:39Z

Yep, I think also, you also should enable FLASH in the defconfig.

Apart that, LGTM

galak · 2018-01-17T17:52:41Z

Can you rebase this?

dwagenk · 2018-01-18T08:20:34Z

@galak i'm waiting for #5171 to get merged. will rebase and clean up then.

dwagenk · 2018-01-18T11:12:29Z

rebased onto #5171 that introduces stm32f072xb SoC.

@superna9999 I removed FLASH from the documentation, since I didn't test it.

dwagenk · 2018-01-18T11:21:25Z

recheck

codecov-io · 2018-01-18T11:38:26Z

Codecov Report

Merging #5405 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5405      +/-   ##
==========================================
- Coverage   54.37%   54.33%   -0.05%     
==========================================
  Files         457      457              
  Lines       43298    43298              
  Branches     8302     8302              
==========================================
- Hits        23545    23524      -21     
- Misses      19614    19635      +21     
  Partials      139      139

Impacted Files	Coverage Δ
...sts/net/ieee802154/l2/src/ieee802154_fake_driver.c	`74.35% <0%> (-15.39%)`	⬇️
include/net/net_ip.h	`67.36% <0%> (-4.87%)`	⬇️
subsys/net/ip/6lo.c	`38.73% <0%> (-2.79%)`	⬇️
tests/kernel/obj_tracing/src/philosopher.c	`88.88% <0%> (+16.66%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5d64aa...f5c3dbc. Read the comment docs.

dwagenk · 2018-01-18T13:51:16Z

~~do not merge~~

~~I had some issues with the uart configuration right now and want to look into it tomorrow~~

Edit:
Errors resolved, please review and marge after #5171

Background: UART2 is not really usable on this board. Pinmuxing it to PA14/PA15 works sometimes, but interferes with programming/debugging port and PA2/PA3 are occupied by linear touch sensor.
So I removed UART2 from board support commit completely.

dwagenk · 2018-01-26T08:10:56Z

now that #5171 is merged this should be ready to get merged as well.

@ydamigos can you please take a look at the SPI configuration through device tree? SPI_loopback test works, but I'm not familiar with dts, so I stay a little uncertain, if all is correct. I basically copied your work from 96b_carbon board and adjustet the dts.fixup file to use the SPI_FIFO versions instead.

@superna9999 @erwango @dbkinder can you please take a look at it again?

ydamigos

LGTM. Some minor non blocking comments. I don't have the hardware to test it.

ydamigos · 2018-01-26T08:14:13Z

tests/drivers/spi/spi_loopback/prj_stm32f072b_disco.conf

+CONFIG_BUILD_TIMESTAMP=y
+CONFIG_SYS_LOG=y
+CONFIG_SPI=y
+CONFIG_SPI_LEGACY_API=n


It isn't needed. It defaults to n in arm/soc/st_stm32/common/Kconfig.defconfig.series when SPI and one SPI_x port are enabled.

ydamigos · 2018-01-26T08:14:28Z

tests/drivers/spi/spi_loopback/prj_stm32f072b_disco.conf

+CONFIG_SPI=y
+CONFIG_SPI_LEGACY_API=n
+CONFIG_SYS_LOG_SPI_LEVEL=1
+CONFIG_SPI_STM32=y


It isn't needed. It defaults to y in arm/soc/st_stm32/common/Kconfig.defconfig.series when SPI and one SPI_x port are enabled.

ydamigos · 2018-01-26T08:17:39Z

tests/drivers/spi/spi_loopback/prj_stm32f072b_disco.conf

+CONFIG_SPI_LEGACY_API=n
+CONFIG_SYS_LOG_SPI_LEVEL=1
+CONFIG_SPI_STM32=y
+CONFIG_SPI_STM32_INTERRUPT=y


It isn't needed. It defaults to y in boards Kconfig.defconfig when SPI is enabled.

ydamigos · 2018-01-26T08:17:56Z

tests/drivers/spi/spi_loopback/prj_stm32f072b_disco.conf

+CONFIG_SYS_LOG_SPI_LEVEL=1
+CONFIG_SPI_STM32=y
+CONFIG_SPI_STM32_INTERRUPT=y
+CONFIG_SPI_1=y


It isn't needed. It defaults to y in boards Kconfig.defconfig when SPI is enabled.

erwango · 2018-01-26T08:36:20Z

@dwagenk : Approved, but please take into account @ydamigos comments

dwagenk · 2018-01-26T09:28:06Z

@erwango @ydamigos what do you think of moving those changes to a seperate PR that cleans up the spi_loopback test?
It would effect also those files in tests\drivers\spi\spi_loopback:

prj_96b_carbon_irq.conf
prj_96b_carbon_polled.conf
prj_nucleo_f091rc.conf (which doesn't support SPI right now anyhow, see spi: stm32: convert remaining boards that support SPI to using dts #5836)
prj_nucleo_l432kc.conf (which doesn't support SPI right now anyhow, see spi: stm32: convert remaining boards that support SPI to using dts #5836)

ydamigos · 2018-01-26T09:31:44Z

what do you think of moving those changes to a seperate PR that cleans up the spi_loopback test?

@dwagenk It's fine with me.

erwango · 2018-01-26T09:36:30Z

what do you think of moving those changes to a seperate PR that cleans up the spi_loopback test?

@dwagenk : Sure, go ahead

dwagenk · 2018-01-26T11:33:19Z

I won't have time for a follow up pr for the spi_loopback test before monday, but would like to get this closed soon (it's been open quite some time). Can you merge it now anyhow, or at least the two first commits (without adding the board to spi_loopback test)?

erwango · 2018-01-26T12:42:06Z

Can you merge it now anyhow, or at least the two first commits (without adding the board to spi_loopback test)?

@dwagenk: Maybe you can just remove last commit.

Adds pinmux defines to use I2C2 at PB10/PB11 for stm32f0-based boards. Needed for stm32f072b_disco board to use extension connector Signed-off-by: Daniel Wagenknecht <[email protected]>

Support the ST STM32F072B-DISCO discovery board with STM32F072RB SoC Signed-off-by: Daniel Wagenknecht <[email protected]>

galak · 2018-01-26T15:23:47Z

I pushed an update and dropped the SPI patch so we can merge this board port

dwagenk · 2018-01-29T06:39:08Z

@galak thanks!

dwagenk requested review from dbkinder, erwango, nashif and SebastianBoe as code owners December 15, 2017 08:21

SebastianBoe removed their request for review December 15, 2017 09:08

galak self-assigned this Dec 15, 2017

galak added area: ARM ARM (32-bit) Architecture area: Boards platform: STM32 ST Micro STM32 labels Dec 15, 2017

dbkinder suggested changes Dec 15, 2017

View reviewed changes

dbkinder previously approved these changes Dec 18, 2017

View reviewed changes

dwagenk dismissed dbkinder’s stale review via 6dc386e December 19, 2017 08:28

erwango reviewed Dec 19, 2017

View reviewed changes

superna9999 previously approved these changes Dec 21, 2017

View reviewed changes

galak force-pushed the arm branch 2 times, most recently from ee5b12f to f95e5fd Compare January 11, 2018 22:07

dwagenk dismissed superna9999’s stale review via bcac8ee January 18, 2018 11:08

dwagenk requested review from mbolivar, tbursztyka and ydamigos as code owners January 18, 2018 11:08

dwagenk changed the base branch from arm to master January 18, 2018 11:09

dwagenk mentioned this pull request Jan 18, 2018

Add support for the STM32F072-EVAL Board #5171

Merged

ydamigos reviewed Jan 26, 2018

View reviewed changes

erwango approved these changes Jan 26, 2018

View reviewed changes

Daniel Wagenknecht added 2 commits January 26, 2018 09:21

pinmux: stm32f0: add additional defines for I2C2

34f76be

Adds pinmux defines to use I2C2 at PB10/PB11 for stm32f0-based boards. Needed for stm32f072b_disco board to use extension connector Signed-off-by: Daniel Wagenknecht <[email protected]>

boards: arm: add support for STM32F072B-DISCO

f5c3dbc

Support the ST STM32F072B-DISCO discovery board with STM32F072RB SoC Signed-off-by: Daniel Wagenknecht <[email protected]>

galak merged commit d6bedd7 into zephyrproject-rtos:master Jan 26, 2018

This was referenced Jan 28, 2018

STM32: move dts.fixup files to soc level and clean up spi_loopback test #5858

Closed

STM32: move dts.fixup files to soc level #5859

Merged

dwagenk mentioned this pull request Jan 29, 2018

Making SPI Loopback Test more generic #5885

Merged

dwagenk deleted the stm32f072b_disco branch February 15, 2018 09:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

boards: arm: add support for stm32f072b_disco board #5405

boards: arm: add support for stm32f072b_disco board #5405

dwagenk commented Dec 15, 2017

dwagenk commented Dec 15, 2017

galak commented Dec 15, 2017

dbkinder left a comment

dbkinder Dec 15, 2017

dwagenk Dec 18, 2017

dwagenk Dec 18, 2017

dwagenk commented Dec 19, 2017

erwango left a comment

superna9999 commented Dec 21, 2017

galak commented Jan 17, 2018

dwagenk commented Jan 18, 2018 •

edited

Loading

dwagenk commented Jan 18, 2018 •

edited

Loading

dwagenk commented Jan 18, 2018

codecov-io commented Jan 18, 2018 •

edited

Loading

dwagenk commented Jan 18, 2018 •

edited

Loading

dwagenk commented Jan 26, 2018

ydamigos left a comment

ydamigos Jan 26, 2018

ydamigos Jan 26, 2018

ydamigos Jan 26, 2018

ydamigos Jan 26, 2018

erwango commented Jan 26, 2018

dwagenk commented Jan 26, 2018

ydamigos commented Jan 26, 2018

erwango commented Jan 26, 2018

dwagenk commented Jan 26, 2018

erwango commented Jan 26, 2018

galak commented Jan 26, 2018

dwagenk commented Jan 29, 2018

boards: arm: add support for stm32f072b_disco board #5405

boards: arm: add support for stm32f072b_disco board #5405

Conversation

dwagenk commented Dec 15, 2017

dwagenk commented Dec 15, 2017

galak commented Dec 15, 2017

dbkinder left a comment

Choose a reason for hiding this comment

dbkinder Dec 15, 2017

Choose a reason for hiding this comment

dwagenk Dec 18, 2017

Choose a reason for hiding this comment

dwagenk Dec 18, 2017

Choose a reason for hiding this comment

dwagenk commented Dec 19, 2017

erwango left a comment

Choose a reason for hiding this comment

superna9999 commented Dec 21, 2017

galak commented Jan 17, 2018

dwagenk commented Jan 18, 2018 • edited Loading

dwagenk commented Jan 18, 2018 • edited Loading

dwagenk commented Jan 18, 2018

codecov-io commented Jan 18, 2018 • edited Loading

Codecov Report

dwagenk commented Jan 18, 2018 • edited Loading

dwagenk commented Jan 26, 2018

ydamigos left a comment

Choose a reason for hiding this comment

ydamigos Jan 26, 2018

Choose a reason for hiding this comment

ydamigos Jan 26, 2018

Choose a reason for hiding this comment

ydamigos Jan 26, 2018

Choose a reason for hiding this comment

ydamigos Jan 26, 2018

Choose a reason for hiding this comment

erwango commented Jan 26, 2018

dwagenk commented Jan 26, 2018

ydamigos commented Jan 26, 2018

erwango commented Jan 26, 2018

dwagenk commented Jan 26, 2018

erwango commented Jan 26, 2018

galak commented Jan 26, 2018

dwagenk commented Jan 29, 2018

dwagenk commented Jan 18, 2018 •

edited

Loading

dwagenk commented Jan 18, 2018 •

edited

Loading

codecov-io commented Jan 18, 2018 •

edited

Loading

dwagenk commented Jan 18, 2018 •

edited

Loading