Eth Click #26213
Merged
Eth Click #26213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable GPIO as a workaround to enable some SPI slaves are not correctly controlled using the Flexcomm SPI device. Signed-off-by: Andrei Gansari <[email protected]>
jukkar
requested changes
Jun 16, 2020
| @@ -382,18 +382,18 @@ static void eth_enc28j60_init_mac(struct device *dev) | |||
| } | |||
|
|
|||
| /* Configure MAC address */ | |||
| eth_enc28j60_set_bank(dev, ENC28J60_REG_MAADR0); | |||
| eth_enc28j60_write_reg(dev, ENC28J60_REG_MAADR0, | |||
| eth_enc28j60_set_bank(dev, ENC28J60_REG_MAADR1); | |||
There was a problem hiding this comment.
The enc28j60 was working mostly ok last time I tried without these changes. What are the symptoms if these changes are not done, could you describe these also in commit msg.
There was a problem hiding this comment.
It's a mismatch with the latest reference manual, there is no MAADR0 register.
There was a problem hiding this comment.
Ok. I just have not seen issues regarding Ethernet functionality, so wondering how this mismatch shows itself.
Aligns MAC registers to the latest reference manual. Replaces NULL buffers as some SPI drivers will fail. Signed-off-by: Andrei Gansari <[email protected]>
MaureenHelm
approved these changes
Jun 16, 2020
galak
approved these changes
Jun 17, 2020
jfischer-no
reviewed
Jun 17, 2020
This was referenced Jun 23, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enc28j60
LPCxpress55s69