-
Notifications
You must be signed in to change notification settings - Fork 7.3k
drivers: video: csi: Change sensor dev to source dev #72623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: video: csi: Change sensor dev to source dev #72623
Conversation
Hi, |
A sink could also be an associated device, such as the HDMI to MIPI bridges chips 1, 2, or HDMI CEC controllers 1. An alternative is to use P.S.: There is a chat channel |
dts/bindings/video/nxp,imx-csi.yaml
Outdated
@@ -14,7 +14,8 @@ properties: | |||
interrupts: | |||
required: true | |||
|
|||
sensor: | |||
sdev: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this name is not descriptive, also is this worth breaking backward compatibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@decsny : I can change to "source_dev" (?) to be more descriptive. But the old name "sensor" is definitely not ok for the new support in RT11xx. As explained in the commit message, "sensor" is chosen because at that time, the CSI driver supports only RT10xx where it connects to a sensor. But in RT11xx, it connects to MIPI CSI2 instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, done
7926da2
to
a7749c2
Compare
Can we simply name it 'source' |
The CSI can connect to either a camera sensor (as on i.MX RT10xx) or a MIPI CSI-2 receiver (as on i.MX RT11xx). To be generic, change the naming from sensor to source. Signed-off-by: Phi Bang Nguyen <[email protected]>
a7749c2
to
7cea2a4
Compare
Yes, done. But now, I need @danieldegrasse and @decsny approve the PR again ... |
The CSI can connect to either a camera sensor (as on i.MX RT10xx) or a MIPI CSI-2 receiver (as on i.MX RT11xx). To be generic, change the naming from sensor dev to source dev.
This PR is splitted from #69810 to ease the review process and from #72420 to avoid mutual dependency with #71859