Skip to content

boards: qemu: Add support for qemu_max board #85242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

GueqiXie
Copy link

@GueqiXie GueqiXie commented Feb 5, 2025

This PR is the part 1 of a complete submission to ZVM. A draft of the complete PR can be found at:
#84123 ZVM : New-Generation Type 1.5 RTOS Virtualization Solution (Hypervisor)


What is changed?

- Added a new qemu_max board for QEMU emulation. This includes the addition of board-specific files such as Kconfig, defconfig, board.yaml and DTS files under `boards/qemu/max`.

- Added support for multi-core SMP with QEMU through the `qemu_max_qemu_max_smp` configuration and associated DTS and YAML files.

- Updated SoC-specific configurations under `soc/arm/qemu_max`, including Kconfig, SoC-specific settings, and memory regions in `mmu_regions.c`.

- Added device tree include file `qemu-virt-max.dtsi` for enhanced compatibility with the qemu_max board.

Why do we need this change?
- The qemu_max board supports the hardware features of ARMv8.1+, while the existing qemu_cortex_a53 does not.

@vonhust
Copy link

vonhust commented Feb 11, 2025

The CI is ok for further review

@vonhust
Copy link

vonhust commented Feb 11, 2025

@GueqiXie Boards: fix qemu a53 issue should not be coupled with qemu_max, it should be a single commit.

When build tests/drivers/charger/sbs_charger using:

'west build -p -b qemu_cortex_a53/qemu_cortex_a53 \
 tests/drivers/charger/sbs_charger \
 -T drivers.charger.sbs.emulated'

build failed occur.

The error message is below:
  "'reg' property in <Node /i2c@100 in
  '/home/proctor-a/zephyrproject/zephyr/misc/empty_file.c'>
  has length 8, which is not evenly divisible by
  16 (= 4*(<#address-cells> (= 2) + <#size-cells> (= 2)))."

This commit fix it.

Signed-off-by: Guoqi Xie <[email protected]>
@GueqiXie
Copy link
Author

@GueqiXie Boards: fix qemu a53 issue should not be coupled with qemu_max, it should be a single commit.

Thanks, this issue of building qemu_cortex_a53 has been committed as a single commit.

@GueqiXie
Copy link
Author

@rriveramcrus Please help review this commit: 'Tests: fix build issue'. This change should be fine, right?

What is changed?

- Added support for multi-core SMP with QEMU through the
  `qemu_max_qemu_max_smp` configuration and associated
  files.

- Updated SoC-specific configurations files under
  `soc/arm/qemu_max`.

- Added device tree include file `qemu-virt-max.dtsi`.

Why do we need this change?
- The qemu_max board supports the hardware features of
  ARMv8.1+, while the existing qemu_cortex_a53 does not.

Signed-off-by: Guoqi Xie <[email protected]>
@GueqiXie
Copy link
Author

@carlocaione request for review

@cocoeoli
Copy link
Contributor

@npitre request for review

@vonhust
Copy link

vonhust commented Feb 20, 2025

ping for review @carlocaione @npitre @nashif

Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants