-
Notifications
You must be signed in to change notification settings - Fork 7.3k
drivers: flash_stm32_xspi: fix DT accessor for flash size #88392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @tpambor for pushing this fix. However, merging it will get dtc generate warnings (see #88404). So the choice is:
Considering this is not a decision that should be taken lightly, I propose to merge this PR and add a temporary rule to avoid the warnings the time we settle on the direction to be followed. |
The flash size is the second part (size) of the first reg value, not the first part (address) of a nonexistent second reg value. Based-on-patch-by: Armin Brauns <[email protected]> Signed-off-by: Tim Pambor <[email protected]>
About:
Can't find a way to avoid the warning globally on the whole family, so this has to be done per board.. I'd prefer to live with the warnings for the time being. |
I agree to merge this first as other PRs for these boards are blocked by the pipeline failures. |
Hi @tpambor! To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge. Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁 |
This PR is based on #76735 which updated STM flash drivers for QSPI and OSPI but not for XSPI. #87466 then fixed a regression for boards that use QSPI and OSPI but at the same time broke boards with XSPI. This PR aligns XSPI again with QSPI and OSPI and fixes the compile errors currently observed on main for the sample
application_development/code_relocation_nocopy
: