-
Notifications
You must be signed in to change notification settings - Fork 306
content: Distinguish direct and wildcard mentions #646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
(Should we add this to #309?) |
This is one of the pieces of: in that the styling we have matches what was current in web when I started the prototype, but hasn't been updated. Having this separate issue in the tracker is useful, though — for actually tackling #157, we'll probably want separate issues like this one anyway. And it provides an on-point answer for someone wondering why it doesn't match web. I'll edit #157 to point to this. |
We've already done the first part of this: the mentions no longer look like the first screenshot above. Instead they always look like the blue pill in the second screenshot. The remaining task is to have the distinct styling for group mentions. |
This should further help make space for adding more logic here, both for the "channel-wildcard-mention" class (zulip#1064) and for distinguishing different types of mentions (zulip#646, zulip#647).
This should further help make space for adding more logic here, both for the "channel-wildcard-mention" class (zulip#1064) and for distinguishing different types of mentions (zulip#646, zulip#647).
Currently, we don't distinguish the appearance of direct mentions and wildcard mentions:
The web app does that—
—and we should too, probably using the same colors web does.
I'll file a separate issue for a related but different feature: highlighting non-silent mentions of the self-user. That will take more data-model thinking. -> #647
The text was updated successfully, but these errors were encountered: