Skip to content

content: Distinguish direct and wildcard mentions #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrisbobbe opened this issue May 7, 2024 · 3 comments
Open

content: Distinguish direct and wildcard mentions #646

chrisbobbe opened this issue May 7, 2024 · 3 comments
Labels
a-content Parsing and rendering Zulip HTML content, notably message contents a-design Visual and UX design

Comments

@chrisbobbe
Copy link
Collaborator

chrisbobbe commented May 7, 2024

Currently, we don't distinguish the appearance of direct mentions and wildcard mentions:

image

The web app does that—

image

—and we should too, probably using the same colors web does.

I'll file a separate issue for a related but different feature: highlighting non-silent mentions of the self-user. That will take more data-model thinking. -> #647

@chrisbobbe chrisbobbe added the a-content Parsing and rendering Zulip HTML content, notably message contents label May 7, 2024
@chrisbobbe chrisbobbe added this to the Beta 3 milestone May 7, 2024
@chrisbobbe
Copy link
Collaborator Author

(Should we add this to #309?)

@gnprice
Copy link
Member

gnprice commented May 8, 2024

This is one of the pieces of:

in that the styling we have matches what was current in web when I started the prototype, but hasn't been updated.

Having this separate issue in the tracker is useful, though — for actually tackling #157, we'll probably want separate issues like this one anyway. And it provides an on-point answer for someone wondering why it doesn't match web. I'll edit #157 to point to this.

@gnprice
Copy link
Member

gnprice commented Jul 26, 2024

We've already done the first part of this: the mentions no longer look like the first screenshot above. Instead they always look like the blue pill in the second screenshot.

The remaining task is to have the distinct styling for group mentions.

gnprice added a commit to gnprice/zulip-flutter that referenced this issue Nov 25, 2024
This should further help make space for adding more logic here,
both for the "channel-wildcard-mention" class (zulip#1064) and for
distinguishing different types of mentions (zulip#646, zulip#647).
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Dec 3, 2024
This should further help make space for adding more logic here,
both for the "channel-wildcard-mention" class (zulip#1064) and for
distinguishing different types of mentions (zulip#646, zulip#647).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-content Parsing and rendering Zulip HTML content, notably message contents a-design Visual and UX design
Projects
Status: No status
Development

No branches or pull requests

2 participants