-
Notifications
You must be signed in to change notification settings - Fork 306
content: Highlight non-silent mentions of the self-user #647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Milestone
Comments
(Should we add this to #309?) |
In case it's helpful, note the unsubscribed channel edge case: zulip/zulip#27765. |
This was referenced Aug 19, 2024
Closed
gnprice
added a commit
to gnprice/zulip-flutter
that referenced
this issue
Nov 25, 2024
This should further help make space for adding more logic here, both for the "channel-wildcard-mention" class (zulip#1064) and for distinguishing different types of mentions (zulip#646, zulip#647).
gnprice
added a commit
to gnprice/zulip-flutter
that referenced
this issue
Dec 3, 2024
This should further help make space for adding more logic here, both for the "channel-wildcard-mention" class (zulip#1064) and for distinguishing different types of mentions (zulip#646, zulip#647).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This probably makes sense to do after #646.
We should highlight non-silent mentions of the self-user, following web, so that users can easily see when a mention is intended to get their attention.
For some examples (and here I'm logged in as the "Chris Bobbe" account):
Notice the highlighting is done in two ways:
Implementation
To determine if the self-user is mentioned, we'll use the corresponding per-user flags on the message. Any of the "mentioned" flags here (some of which are to be added by #894):
https://zulip.com/api/update-message-flags#available-flags
mean that the self-user was mentioned.
That's enough to know we should highlight the message. Then to highlight the mention within the message, if one or more of those flags is set we'll search the message content to find the corresponding mentions.
The text was updated successfully, but these errors were encountered: