content [nfc]: Pull out parseUserMention, give regexp less to do #1086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PIG208
reviewed
Dec 3, 2024
| } | ||
|
|
||
| if (i != classes.length) { | ||
| // There was some class we didn't expect. |
There was a problem hiding this comment.
The singular is intentional: there's at least one class we didn't expect, namely the one at position i.
(Grammatically it'd be either "was some class" or "were some classes".)
PIG208
added
integration review
|
Thanks for the review! Merging. |
This gives us more breathing room for making this handling more complicated, as we'll need for the new "channel-wildcard-mention" class (zulip#1064).
This should further help make space for adding more logic here, both for the "channel-wildcard-mention" class (zulip#1064) and for distinguishing different types of mentions (zulip#646, zulip#647).
gnprice
force-pushed
the
pr-parse-mention
branch
from
215527a to
d21d76b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives us more breathing room for making this handling more
complicated, as we'll need for the new "channel-wildcard-mention"
class (#1064) and for distinguishing different types of mentions (#646, #647).
Prompted by:
#1073 (comment)
(/cc @sm-sayedi, @PIG208).