Skip to content

Add process tags as list to remote config payload #8705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

amarziali
Copy link
Collaborator

@amarziali amarziali commented Apr 17, 2025

What Does This Do

Adds Process tags in the remote config payload under client_tracer.process_tags

See also https://github.com/DataDog/datadog-agent/pull/36049/files and #8698

Motivation

Additional Notes

Contributor Checklist

Jira ticket: AIDM-628

@amarziali amarziali added type: enhancement tag: do not merge Do not merge changes comp: remote config Configuration at Runtime labels Apr 17, 2025
@pr-commenter
Copy link

pr-commenter bot commented Apr 17, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/process_tags_rc
git_commit_date 1745931349 1745930968
git_commit_sha 52f61bb 82e4dd9
release_version 1.49.0-SNAPSHOT~52f61bb471 1.49.0-SNAPSHOT~82e4dd9222
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1745934159 1745934159
ci_job_id 916635493 916635493
ci_pipeline_id 63600049 63600049
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-stvtq5db-project-304-concurrent-1-kzhlhc3a 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-stvtq5db-project-304-concurrent-1-kzhlhc3a 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 67 metrics, 4 unstable metrics.

Startup time reports for insecure-bank
gantt
    title insecure-bank - global startup overhead: candidate=1.49.0-SNAPSHOT~82e4dd9222, baseline=1.49.0-SNAPSHOT~52f61bb471

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.008 s) : 0, 1007591
Total [baseline] (8.641 s) : 0, 8640780
Agent [candidate] (1.005 s) : 0, 1005495
Total [candidate] (8.618 s) : 0, 8617529
section iast
Agent [baseline] (1.146 s) : 0, 1145628
Total [baseline] (9.222 s) : 0, 9222126
Agent [candidate] (1.145 s) : 0, 1145453
Total [candidate] (9.219 s) : 0, 9218611
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.136 s) : 0, 1136287
Total [baseline] (9.165 s) : 0, 9164718
Agent [candidate] (1.135 s) : 0, 1135327
Total [candidate] (9.209 s) : 0, 9209359
section iast_TELEMETRY_OFF
Agent [baseline] (1.134 s) : 0, 1133596
Total [baseline] (9.165 s) : 0, 9164876
Agent [candidate] (1.141 s) : 0, 1141231
Total [candidate] (9.183 s) : 0, 9183482
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.008 s -
Agent iast 1.146 s 138.037 ms (13.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.136 s 128.696 ms (12.8%)
Agent iast_TELEMETRY_OFF 1.134 s 126.005 ms (12.5%)
Total tracing 8.641 s -
Total iast 9.222 s 581.346 ms (6.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.165 s 523.937 ms (6.1%)
Total iast_TELEMETRY_OFF 9.165 s 524.095 ms (6.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.005 s -
Agent iast 1.145 s 139.958 ms (13.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.135 s 129.832 ms (12.9%)
Agent iast_TELEMETRY_OFF 1.141 s 135.737 ms (13.5%)
Total tracing 8.618 s -
Total iast 9.219 s 601.083 ms (7.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.209 s 591.831 ms (6.9%)
Total iast_TELEMETRY_OFF 9.183 s 565.953 ms (6.6%)
gantt
    title insecure-bank - break down per module: candidate=1.49.0-SNAPSHOT~82e4dd9222, baseline=1.49.0-SNAPSHOT~52f61bb471

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (670.191 ms) : 0, 670191
BytebuddyAgent [candidate] (670.547 ms) : 0, 670547
GlobalTracer [baseline] (239.869 ms) : 0, 239869
GlobalTracer [candidate] (240.039 ms) : 0, 240039
AppSec [baseline] (54.482 ms) : 0, 54482
AppSec [candidate] (54.782 ms) : 0, 54782
Debugger [baseline] (7.614 ms) : 0, 7614
Debugger [candidate] (6.152 ms) : 0, 6152
Remote Config [baseline] (693.918 µs) : 0, 694
Remote Config [candidate] (704.9 µs) : 0, 705
Telemetry [baseline] (11.251 ms) : 0, 11251
Telemetry [candidate] (9.915 ms) : 0, 9915
section iast
BytebuddyAgent [baseline] (796.603 ms) : 0, 796603
BytebuddyAgent [candidate] (795.631 ms) : 0, 795631
GlobalTracer [baseline] (231.014 ms) : 0, 231014
GlobalTracer [candidate] (231.68 ms) : 0, 231680
IAST [baseline] (23.04 ms) : 0, 23040
IAST [candidate] (23.119 ms) : 0, 23119
AppSec [baseline] (56.902 ms) : 0, 56902
AppSec [candidate] (56.883 ms) : 0, 56883
Debugger [baseline] (5.973 ms) : 0, 5973
Debugger [candidate] (6.004 ms) : 0, 6004
Remote Config [baseline] (602.519 µs) : 0, 603
Remote Config [candidate] (593.212 µs) : 0, 593
Telemetry [baseline] (7.967 ms) : 0, 7967
Telemetry [candidate] (7.984 ms) : 0, 7984
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (789.651 ms) : 0, 789651
BytebuddyAgent [candidate] (788.667 ms) : 0, 788667
GlobalTracer [baseline] (229.76 ms) : 0, 229760
GlobalTracer [candidate] (229.477 ms) : 0, 229477
IAST [baseline] (22.852 ms) : 0, 22852
IAST [candidate] (22.733 ms) : 0, 22733
AppSec [baseline] (56.238 ms) : 0, 56238
AppSec [candidate] (56.733 ms) : 0, 56733
Debugger [baseline] (5.892 ms) : 0, 5892
Debugger [candidate] (5.886 ms) : 0, 5886
Remote Config [baseline] (582.875 µs) : 0, 583
Remote Config [candidate] (590.994 µs) : 0, 591
Telemetry [baseline] (7.881 ms) : 0, 7881
Telemetry [candidate] (7.866 ms) : 0, 7866
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (787.355 ms) : 0, 787355
BytebuddyAgent [candidate] (792.798 ms) : 0, 792798
GlobalTracer [baseline] (229.716 ms) : 0, 229716
GlobalTracer [candidate] (231.206 ms) : 0, 231206
IAST [baseline] (22.437 ms) : 0, 22437
IAST [candidate] (22.591 ms) : 0, 22591
AppSec [baseline] (56.35 ms) : 0, 56350
AppSec [candidate] (56.736 ms) : 0, 56736
Debugger [baseline] (5.92 ms) : 0, 5920
Debugger [candidate] (5.93 ms) : 0, 5930
Remote Config [baseline] (601.955 µs) : 0, 602
Remote Config [candidate] (609.749 µs) : 0, 610
Telemetry [baseline] (7.764 ms) : 0, 7764
Telemetry [candidate] (7.831 ms) : 0, 7831
Loading
Startup time reports for petclinic
gantt
    title petclinic - global startup overhead: candidate=1.49.0-SNAPSHOT~82e4dd9222, baseline=1.49.0-SNAPSHOT~52f61bb471

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.009 s) : 0, 1009108
Total [baseline] (10.441 s) : 0, 10441037
Agent [candidate] (1.014 s) : 0, 1014082
Total [candidate] (10.523 s) : 0, 10523136
section appsec
Agent [baseline] (1.151 s) : 0, 1151125
Total [baseline] (10.631 s) : 0, 10631183
Agent [candidate] (1.156 s) : 0, 1156023
Total [candidate] (10.68 s) : 0, 10679594
section iast
Agent [baseline] (1.147 s) : 0, 1146570
Total [baseline] (10.911 s) : 0, 10910524
Agent [candidate] (1.137 s) : 0, 1136808
Total [candidate] (10.816 s) : 0, 10815635
section profiling
Agent [baseline] (1.259 s) : 0, 1259382
Total [baseline] (10.855 s) : 0, 10855264
Agent [candidate] (1.257 s) : 0, 1257489
Total [candidate] (10.755 s) : 0, 10755128
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.009 s -
Agent appsec 1.151 s 142.017 ms (14.1%)
Agent iast 1.147 s 137.462 ms (13.6%)
Agent profiling 1.259 s 250.274 ms (24.8%)
Total tracing 10.441 s -
Total appsec 10.631 s 190.146 ms (1.8%)
Total iast 10.911 s 469.487 ms (4.5%)
Total profiling 10.855 s 414.227 ms (4.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.014 s -
Agent appsec 1.156 s 141.941 ms (14.0%)
Agent iast 1.137 s 122.727 ms (12.1%)
Agent profiling 1.257 s 243.408 ms (24.0%)
Total tracing 10.523 s -
Total appsec 10.68 s 156.458 ms (1.5%)
Total iast 10.816 s 292.499 ms (2.8%)
Total profiling 10.755 s 231.993 ms (2.2%)
gantt
    title petclinic - break down per module: candidate=1.49.0-SNAPSHOT~82e4dd9222, baseline=1.49.0-SNAPSHOT~52f61bb471

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (671.366 ms) : 0, 671366
BytebuddyAgent [candidate] (675.833 ms) : 0, 675833
GlobalTracer [baseline] (240.362 ms) : 0, 240362
GlobalTracer [candidate] (241.307 ms) : 0, 241307
AppSec [baseline] (54.893 ms) : 0, 54893
AppSec [candidate] (55.109 ms) : 0, 55109
Debugger [baseline] (6.169 ms) : 0, 6169
Debugger [candidate] (6.188 ms) : 0, 6188
Remote Config [baseline] (715.678 µs) : 0, 716
Remote Config [candidate] (724.123 µs) : 0, 724
Telemetry [baseline] (12.256 ms) : 0, 12256
Telemetry [candidate] (11.405 ms) : 0, 11405
section appsec
BytebuddyAgent [baseline] (689.699 ms) : 0, 689699
BytebuddyAgent [candidate] (693.183 ms) : 0, 693183
GlobalTracer [baseline] (237.222 ms) : 0, 237222
GlobalTracer [candidate] (237.606 ms) : 0, 237606
AppSec [baseline] (175.366 ms) : 0, 175366
AppSec [candidate] (176.408 ms) : 0, 176408
Debugger [baseline] (5.87 ms) : 0, 5870
Debugger [candidate] (5.878 ms) : 0, 5878
Remote Config [baseline] (645.719 µs) : 0, 646
Remote Config [candidate] (640.005 µs) : 0, 640
Telemetry [baseline] (7.801 ms) : 0, 7801
Telemetry [candidate] (7.81 ms) : 0, 7810
IAST [baseline] (22.071 ms) : 0, 22071
IAST [candidate] (21.946 ms) : 0, 21946
section iast
BytebuddyAgent [baseline] (796.044 ms) : 0, 796044
BytebuddyAgent [candidate] (789.62 ms) : 0, 789620
GlobalTracer [baseline] (232.325 ms) : 0, 232325
GlobalTracer [candidate] (229.814 ms) : 0, 229814
AppSec [baseline] (56.984 ms) : 0, 56984
AppSec [candidate] (56.607 ms) : 0, 56607
Debugger [baseline] (5.943 ms) : 0, 5943
Debugger [candidate] (5.912 ms) : 0, 5912
Remote Config [baseline] (596.156 µs) : 0, 596
Remote Config [candidate] (590.503 µs) : 0, 591
Telemetry [baseline] (7.99 ms) : 0, 7990
Telemetry [candidate] (7.925 ms) : 0, 7925
IAST [baseline] (23.119 ms) : 0, 23119
IAST [candidate] (22.896 ms) : 0, 22896
section profiling
ProfilingAgent [baseline] (96.954 ms) : 0, 96954
ProfilingAgent [candidate] (96.109 ms) : 0, 96109
BytebuddyAgent [baseline] (665.957 ms) : 0, 665957
BytebuddyAgent [candidate] (666.516 ms) : 0, 666516
GlobalTracer [baseline] (376.88 ms) : 0, 376880
GlobalTracer [candidate] (375.988 ms) : 0, 375988
AppSec [baseline] (54.176 ms) : 0, 54176
AppSec [candidate] (53.623 ms) : 0, 53623
Debugger [baseline] (6.177 ms) : 0, 6177
Debugger [candidate] (6.153 ms) : 0, 6153
Remote Config [baseline] (652.895 µs) : 0, 653
Remote Config [candidate] (643.264 µs) : 0, 643
Telemetry [baseline] (8.263 ms) : 0, 8263
Telemetry [candidate] (8.154 ms) : 0, 8154
Profiling [baseline] (96.978 ms) : 0, 96978
Profiling [candidate] (96.133 ms) : 0, 96133
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-04-29T13:10:06 2025-04-29T13:17:49
git_branch master andrea.marziali/process_tags_rc
git_commit_date 1745931349 1745930968
git_commit_sha 52f61bb 82e4dd9
release_version 1.49.0-SNAPSHOT~52f61bb471 1.49.0-SNAPSHOT~82e4dd9222
start_time 2025-04-29T13:09:52 2025-04-29T13:17:35
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1745933067 1745933067
ci_job_id 916635495 916635495
ci_pipeline_id 63600049 63600049
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-df2tp9k5-project-304-concurrent-1-kp4xvjpl 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-df2tp9k5-project-304-concurrent-1-kp4xvjpl 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics.

Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~82e4dd9222, baseline=1.49.0-SNAPSHOT~52f61bb471
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.362 ms) : 1342, 1382
.   : milestone, 1362,
appsec (1.746 ms) : 1723, 1769
.   : milestone, 1746,
appsec_no_iast (1.725 ms) : 1701, 1748
.   : milestone, 1725,
code_origins (1.693 ms) : 1666, 1720
.   : milestone, 1693,
iast (1.527 ms) : 1501, 1552
.   : milestone, 1527,
profiling (1.527 ms) : 1503, 1551
.   : milestone, 1527,
tracing (1.49 ms) : 1465, 1515
.   : milestone, 1490,
section candidate
no_agent (1.361 ms) : 1340, 1381
.   : milestone, 1361,
appsec (1.737 ms) : 1712, 1762
.   : milestone, 1737,
appsec_no_iast (1.739 ms) : 1716, 1763
.   : milestone, 1739,
code_origins (1.675 ms) : 1648, 1701
.   : milestone, 1675,
iast (1.519 ms) : 1494, 1545
.   : milestone, 1519,
profiling (1.536 ms) : 1512, 1561
.   : milestone, 1536,
tracing (1.505 ms) : 1479, 1530
.   : milestone, 1505,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.362 ms [1.342 ms, 1.382 ms] -
appsec 1.746 ms [1.723 ms, 1.769 ms] 383.395 µs (28.1%)
appsec_no_iast 1.725 ms [1.701 ms, 1.748 ms] 362.377 µs (26.6%)
code_origins 1.693 ms [1.666 ms, 1.72 ms] 330.7 µs (24.3%)
iast 1.527 ms [1.501 ms, 1.552 ms] 164.389 µs (12.1%)
profiling 1.527 ms [1.503 ms, 1.551 ms] 164.776 µs (12.1%)
tracing 1.49 ms [1.465 ms, 1.515 ms] 127.478 µs (9.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.361 ms [1.34 ms, 1.381 ms] -
appsec 1.737 ms [1.712 ms, 1.762 ms] 376.441 µs (27.7%)
appsec_no_iast 1.739 ms [1.716 ms, 1.763 ms] 378.581 µs (27.8%)
code_origins 1.675 ms [1.648 ms, 1.701 ms] 314.108 µs (23.1%)
iast 1.519 ms [1.494 ms, 1.545 ms] 158.836 µs (11.7%)
profiling 1.536 ms [1.512 ms, 1.561 ms] 175.727 µs (12.9%)
tracing 1.505 ms [1.479 ms, 1.53 ms] 144.348 µs (10.6%)
Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~82e4dd9222, baseline=1.49.0-SNAPSHOT~52f61bb471
    dateFormat X
    axisFormat %s
section baseline
no_agent (382.136 µs) : 361, 403
.   : milestone, 382,
iast (517.007 µs) : 493, 541
.   : milestone, 517,
iast_FULL (735.317 µs) : 712, 759
.   : milestone, 735,
iast_GLOBAL (574.939 µs) : 552, 598
.   : milestone, 575,
iast_HARDCODED_SECRET_DISABLED (514.818 µs) : 492, 538
.   : milestone, 515,
iast_INACTIVE (469.745 µs) : 447, 493
.   : milestone, 470,
iast_TELEMETRY_OFF (504.907 µs) : 481, 529
.   : milestone, 505,
tracing (457.422 µs) : 436, 479
.   : milestone, 457,
section candidate
no_agent (380.369 µs) : 360, 400
.   : milestone, 380,
iast (524.272 µs) : 501, 547
.   : milestone, 524,
iast_FULL (737.932 µs) : 715, 761
.   : milestone, 738,
iast_GLOBAL (575.984 µs) : 552, 600
.   : milestone, 576,
iast_HARDCODED_SECRET_DISABLED (517.354 µs) : 495, 540
.   : milestone, 517,
iast_INACTIVE (464.318 µs) : 442, 486
.   : milestone, 464,
iast_TELEMETRY_OFF (502.192 µs) : 480, 525
.   : milestone, 502,
tracing (458.434 µs) : 436, 480
.   : milestone, 458,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 382.136 µs [361.46 µs, 402.812 µs] -
iast 517.007 µs [493.298 µs, 540.715 µs] 134.871 µs (35.3%)
iast_FULL 735.317 µs [711.623 µs, 759.011 µs] 353.182 µs (92.4%)
iast_GLOBAL 574.939 µs [551.625 µs, 598.254 µs] 192.804 µs (50.5%)
iast_HARDCODED_SECRET_DISABLED 514.818 µs [492.128 µs, 537.508 µs] 132.683 µs (34.7%)
iast_INACTIVE 469.745 µs [446.85 µs, 492.641 µs] 87.61 µs (22.9%)
iast_TELEMETRY_OFF 504.907 µs [481.012 µs, 528.803 µs] 122.772 µs (32.1%)
tracing 457.422 µs [436.001 µs, 478.844 µs] 75.287 µs (19.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 380.369 µs [360.42 µs, 400.318 µs] -
iast 524.272 µs [501.301 µs, 547.243 µs] 143.903 µs (37.8%)
iast_FULL 737.932 µs [714.792 µs, 761.072 µs] 357.563 µs (94.0%)
iast_GLOBAL 575.984 µs [552.352 µs, 599.616 µs] 195.615 µs (51.4%)
iast_HARDCODED_SECRET_DISABLED 517.354 µs [494.741 µs, 539.967 µs] 136.985 µs (36.0%)
iast_INACTIVE 464.318 µs [442.18 µs, 486.457 µs] 83.95 µs (22.1%)
iast_TELEMETRY_OFF 502.192 µs [479.562 µs, 524.822 µs] 121.823 µs (32.0%)
tracing 458.434 µs [436.385 µs, 480.482 µs] 78.065 µs (20.5%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/process_tags_rc
git_commit_date 1745931349 1745930968
git_commit_sha 52f61bb 82e4dd9
release_version 1.49.0-SNAPSHOT~52f61bb471 1.49.0-SNAPSHOT~82e4dd9222
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1745933841 1745933841
ci_job_id 916635496 916635496
ci_pipeline_id 63600049 63600049
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-yu7uw3kp-project-304-concurrent-1-t8mj4hnc 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-yu7uw3kp-project-304-concurrent-1-t8mj4hnc 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava
gantt
    title biojava - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~82e4dd9222, baseline=1.49.0-SNAPSHOT~52f61bb471
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.546 s) : 15546000, 15546000
.   : milestone, 15546000,
appsec (14.891 s) : 14891000, 14891000
.   : milestone, 14891000,
iast (18.839 s) : 18839000, 18839000
.   : milestone, 18839000,
iast_GLOBAL (17.933 s) : 17933000, 17933000
.   : milestone, 17933000,
profiling (15.767 s) : 15767000, 15767000
.   : milestone, 15767000,
tracing (14.962 s) : 14962000, 14962000
.   : milestone, 14962000,
section candidate
no_agent (14.959 s) : 14959000, 14959000
.   : milestone, 14959000,
appsec (15.107 s) : 15107000, 15107000
.   : milestone, 15107000,
iast (19.081 s) : 19081000, 19081000
.   : milestone, 19081000,
iast_GLOBAL (17.924 s) : 17924000, 17924000
.   : milestone, 17924000,
profiling (15.761 s) : 15761000, 15761000
.   : milestone, 15761000,
tracing (15.117 s) : 15117000, 15117000
.   : milestone, 15117000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.546 s [15.546 s, 15.546 s] -
appsec 14.891 s [14.891 s, 14.891 s] -655.0 ms (-4.2%)
iast 18.839 s [18.839 s, 18.839 s] 3.293 s (21.2%)
iast_GLOBAL 17.933 s [17.933 s, 17.933 s] 2.387 s (15.4%)
profiling 15.767 s [15.767 s, 15.767 s] 221.0 ms (1.4%)
tracing 14.962 s [14.962 s, 14.962 s] -584.0 ms (-3.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.959 s [14.959 s, 14.959 s] -
appsec 15.107 s [15.107 s, 15.107 s] 148.0 ms (1.0%)
iast 19.081 s [19.081 s, 19.081 s] 4.122 s (27.6%)
iast_GLOBAL 17.924 s [17.924 s, 17.924 s] 2.965 s (19.8%)
profiling 15.761 s [15.761 s, 15.761 s] 802.0 ms (5.4%)
tracing 15.117 s [15.117 s, 15.117 s] 158.0 ms (1.1%)
Execution time for tomcat
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~82e4dd9222, baseline=1.49.0-SNAPSHOT~52f61bb471
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
.   : milestone, 1472,
appsec (2.365 ms) : 2319, 2412
.   : milestone, 2365,
iast (2.154 ms) : 2095, 2212
.   : milestone, 2154,
iast_GLOBAL (2.192 ms) : 2133, 2251
.   : milestone, 2192,
profiling (2.018 ms) : 1970, 2066
.   : milestone, 2018,
tracing (1.976 ms) : 1931, 2022
.   : milestone, 1976,
section candidate
no_agent (1.474 ms) : 1462, 1485
.   : milestone, 1474,
appsec (2.369 ms) : 2322, 2415
.   : milestone, 2369,
iast (2.155 ms) : 2096, 2213
.   : milestone, 2155,
iast_GLOBAL (2.201 ms) : 2142, 2260
.   : milestone, 2201,
profiling (2.011 ms) : 1963, 2059
.   : milestone, 2011,
tracing (1.976 ms) : 1931, 2021
.   : milestone, 1976,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.472 ms [1.46 ms, 1.483 ms] -
appsec 2.365 ms [2.319 ms, 2.412 ms] 893.713 µs (60.7%)
iast 2.154 ms [2.095 ms, 2.212 ms] 681.971 µs (46.3%)
iast_GLOBAL 2.192 ms [2.133 ms, 2.251 ms] 720.088 µs (48.9%)
profiling 2.018 ms [1.97 ms, 2.066 ms] 546.377 µs (37.1%)
tracing 1.976 ms [1.931 ms, 2.022 ms] 504.629 µs (34.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.474 ms [1.462 ms, 1.485 ms] -
appsec 2.369 ms [2.322 ms, 2.415 ms] 894.916 µs (60.7%)
iast 2.155 ms [2.096 ms, 2.213 ms] 681.068 µs (46.2%)
iast_GLOBAL 2.201 ms [2.142 ms, 2.26 ms] 727.692 µs (49.4%)
profiling 2.011 ms [1.963 ms, 2.059 ms] 537.446 µs (36.5%)
tracing 1.976 ms [1.931 ms, 2.021 ms] 502.48 µs (34.1%)

@amarziali amarziali removed the tag: do not merge Do not merge changes label Apr 18, 2025
@amarziali amarziali marked this pull request as ready for review April 18, 2025 13:41
@amarziali amarziali requested a review from a team as a code owner April 18, 2025 13:41
@amarziali amarziali requested review from dougqh, ygree and smola April 18, 2025 13:41
Copy link
Member

@smola smola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 assuming this has been sync'd already with the backend.
Also this is a good case to test in system-tests.

Copy link
Contributor

@ygree ygree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amarziali amarziali force-pushed the andrea.marziali/process_tags_rc branch from 5207252 to 61ceb53 Compare April 28, 2025 08:47
@amarziali amarziali force-pushed the andrea.marziali/processtags branch from 78cdcfb to 72beabe Compare April 28, 2025 15:01
@amarziali amarziali requested a review from a team as a code owner April 28, 2025 15:01
Base automatically changed from andrea.marziali/processtags to master April 29, 2025 12:45
@amarziali amarziali force-pushed the andrea.marziali/process_tags_rc branch from 61ceb53 to 82e4dd9 Compare April 29, 2025 12:49
@amarziali amarziali enabled auto-merge (squash) April 29, 2025 13:00
@amarziali amarziali merged commit 74633af into master Apr 29, 2025
453 of 455 checks passed
@amarziali amarziali deleted the andrea.marziali/process_tags_rc branch April 29, 2025 13:57
@github-actions github-actions bot added this to the 1.49.0 milestone Apr 29, 2025
svc-squareup-copybara pushed a commit to cashapp/misk that referenced this pull request May 7, 2025
| Package | Type | Package file | Manager | Update | Change |
|---|---|---|---|---|---|
|
[com.google.cloud:google-cloud-logging](https://github.com/googleapis/java-logging)
| dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`3.22.2` -> `3.22.3` |
|
[com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore)
| dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.28.0` -> `2.28.1` |
| [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java)
| dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`1.48.2` -> `1.49.0` |
| [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.36` -> `2.31.37` |
| [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.36` -> `2.31.37` |
|
[software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava)
| dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.36` -> `2.31.37` |
| [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.36` -> `2.31.37` |
| [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.36` -> `2.31.37` |
| [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.36` -> `2.31.37` |
| [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.36` -> `2.31.37` |

---

### Release Notes

<details>
<summary>googleapis/java-logging
(com.google.cloud:google-cloud-logging)</summary>

###
[`v3.22.3`](https://github.com/googleapis/java-logging/blob/HEAD/CHANGELOG.md#3223-2025-05-06)

##### Bug Fixes

- **deps:** Update the Java code generator (gapic-generator-java) to
2.56.3
([844f4fa](googleapis/java-logging@844f4fa))

##### Dependencies

- Update dependency com.google.cloud:sdk-platform-java-config to v3.46.3
([#&#8203;1801](googleapis/java-logging#1801))
([d7aa7bc](googleapis/java-logging@d7aa7bc))
- Update dependency com.google.cloud:sdk-platform-java-config to v3.47.0
([#&#8203;1803](googleapis/java-logging#1803))
([5967ffe](googleapis/java-logging@5967ffe))
- Update googleapis/sdk-platform-java action to v2.57.0
([#&#8203;1804](googleapis/java-logging#1804))
([e9a27ec](googleapis/java-logging@e9a27ec))

</details>

<details>
<summary>googleapis/java-datastore
(com.google.cloud:google-cloud-datastore)</summary>

###
[`v2.28.1`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2281-2025-05-06)

##### Dependencies

- Update dependency com.google.cloud:sdk-platform-java-config to v3.47.0
([#&#8203;1841](googleapis/java-datastore#1841))
([ac393e6](googleapis/java-datastore@ac393e6))
- Update googleapis/sdk-platform-java action to v2.57.0
([#&#8203;1842](googleapis/java-datastore#1842))
([0745906](googleapis/java-datastore@0745906))

</details>

<details>
<summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary>

###
[`v1.49.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.49.0):
1.49.0

### Components

#### Configuration at Runtime

- ✨ Add process tags as list to remote config payload
([#&#8203;8705](DataDog/dd-trace-java#8705) -
[@&#8203;amarziali](https://github.com/amarziali))

#### Continuous Integration Visibility

- 🐛 Add span propagation for Pekko scheduled tasks
([#&#8203;8765](DataDog/dd-trace-java#8765) -
[@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog))
- ✨ Update test.retry_reason to use full name of the feature
([#&#8203;8689](DataDog/dd-trace-java#8689) -
[@&#8203;daniel-mohedano](https://github.com/daniel-mohedano))
- 🧹 Remove unused TestEventsHandler methods
([#&#8203;8674](DataDog/dd-trace-java#8674) -
[@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog))

#### Dynamic Instrumentation

- 🐛 Fix exclude identifiers normalization
([#&#8203;8742](DataDog/dd-trace-java#8742) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- ✨ Make source file tracking asynchronous
([#&#8203;8684](DataDog/dd-trace-java#8684) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- ✨ Add scope filtering for symbol extraction
([#&#8203;8676](DataDog/dd-trace-java#8676) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- ✨ Add support for [@&#8203;key](https://github.com/key) and
[@&#8203;value](https://github.com/value) for Map filtering
([#&#8203;8669](DataDog/dd-trace-java#8669) -
[@&#8203;jpbempel](https://github.com/jpbempel))

#### Library Injection

- ✨ Add system property to force injection of the tracing
library even though multiple javaagents have been detected
([#&#8203;8697](DataDog/dd-trace-java#8697) -
[@&#8203;cecile75](https://github.com/cecile75))

#### Metrics

- ✨ Allow dogstatsd port to be configurable with
DD_DOGSTATSD_PORT
([#&#8203;8693](DataDog/dd-trace-java#8693) -
[@&#8203;randomanderson](https://github.com/randomanderson))

#### Profiling

- ✨ Bump ddprof-java to 1.25.1
([#&#8203;8750](DataDog/dd-trace-java#8750) -
[@&#8203;jbachorik](https://github.com/jbachorik))
- 🐛 Remove cleanup-on-shutdown for temporary files
([#&#8203;8746](DataDog/dd-trace-java#8746) -
[@&#8203;jbachorik](https://github.com/jbachorik))
- ✨⚡ Replace a regex-based SMAP parser with a hand-crafted
one
([#&#8203;8730](DataDog/dd-trace-java#8730) -
[@&#8203;jbachorik](https://github.com/jbachorik))
- ✨ Improve error reporting on profiler startup
([#&#8203;8714](DataDog/dd-trace-java#8714) -
[@&#8203;jbachorik](https://github.com/jbachorik))
- ✨ Exclude ProxyLeakTask exception from exception profiling
([#&#8203;8666](DataDog/dd-trace-java#8666) -
[@&#8203;jbachorik](https://github.com/jbachorik))
- ✨ Use jvmstat for JDKs 9+ programmatically
([#&#8203;8641](DataDog/dd-trace-java#8641) -
[@&#8203;MattAlp](https://github.com/MattAlp))

#### Telemetry

- ✨ Allow dogstatsd port to be configurable with
DD_DOGSTATSD_PORT
([#&#8203;8693](DataDog/dd-trace-java#8693) -
[@&#8203;randomanderson](https://github.com/randomanderson))
- 🐛 Fix appsec.waf.requests telemetry metric
([#&#8203;8644](DataDog/dd-trace-java#8644) -
[@&#8203;jandro996](https://github.com/jandro996))

#### Tracer core

- ✨ Exclude jackson afterburner dynamic classes from
instrumentation
([#&#8203;8747](DataDog/dd-trace-java#8747) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Introduce Java 8 bytecode bridge for instrumentation API
([#&#8203;8736](DataDog/dd-trace-java#8736) -
[@&#8203;PerfectSlayer](https://github.com/PerfectSlayer))
- ⚡🧹 Use byte-buddy classes optimized for Java8+
([#&#8203;8735](DataDog/dd-trace-java#8735) -
[@&#8203;mcculls](https://github.com/mcculls))
- 🐛 Do not set the hibernate or datanucleus span service name when
disabled
([#&#8203;8727](DataDog/dd-trace-java#8727) -
[@&#8203;ygree](https://github.com/ygree))
- ✨ Update bytebuddy and ASM to support JDK 24
([#&#8203;8720](DataDog/dd-trace-java#8720) -
[@&#8203;sarahchen6](https://github.com/sarahchen6))
- 🐛 Turn off JDK socket support by default
([#&#8203;8715](DataDog/dd-trace-java#8715) -
[@&#8203;mcculls](https://github.com/mcculls))
- 🐛 Log warning when trace buffer overflow occurs
([#&#8203;8712](DataDog/dd-trace-java#8712) -
[@&#8203;ygree](https://github.com/ygree))
- ✨🧪 Introducing an internal integration name
([#&#8203;8708](DataDog/dd-trace-java#8708) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Add process tags to client stats payload
([#&#8203;8704](DataDog/dd-trace-java#8704) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Collect process tags for tracing
([#&#8203;8698](DataDog/dd-trace-java#8698) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Stable Config file: target system properties in
process_arguments and support template variables in YamlParser
([#&#8203;8690](DataDog/dd-trace-java#8690) -
[@&#8203;mtoffl01](https://github.com/mtoffl01))
- ✨⚡ Use prefix trie for proxy ignores
([#&#8203;8678](DataDog/dd-trace-java#8678) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Allow agent to be automatically injected when running aside
Log4J patch agent
([#&#8203;8648](DataDog/dd-trace-java#8648) -
[@&#8203;paullegranddc](https://github.com/paullegranddc))
- ✨ Use jvmstat for JDKs 9+ programmatically
([#&#8203;8641](DataDog/dd-trace-java#8641) -
[@&#8203;MattAlp](https://github.com/MattAlp))

#### Tracer internal logging

- 🐛 Delete print line
([#&#8203;8686](DataDog/dd-trace-java#8686) -
[@&#8203;sarahchen6](https://github.com/sarahchen6))

### Instrumentations

#### Akka instrumentation

- 🐛 Handle reentrant scope cleanup in Akka/Pekko actor
instrumentations
([#&#8203;8722](DataDog/dd-trace-java#8722) -
[@&#8203;mcculls](https://github.com/mcculls))

#### Apache Spark instrumentation

- ✨ Use OpenLineage root parent information to generate trace
id ([#&#8203;8726](DataDog/dd-trace-java#8726)
- [@&#8203;mobuchowski](https://github.com/mobuchowski))
- ✨ Spark job cancellation no longer marks application as
failed
([#&#8203;8701](DataDog/dd-trace-java#8701) -
[@&#8203;paul-laffon-dd](https://github.com/paul-laffon-dd))

#### JDBC instrumentation

- 💡 Add support for sybase tds jdbc driver
([#&#8203;8764](DataDog/dd-trace-java#8764) -
[@&#8203;amarziali](https://github.com/amarziali))

#### Kotlin instrumentation

- 🐛 Take defensive copy of parent scope stack when closing nested
coroutines
([#&#8203;8749](DataDog/dd-trace-java#8749) -
[@&#8203;mcculls](https://github.com/mcculls))

#### Reactor instrumentation

- ✨⚡ Do not inspect reactor context when not needed
([#&#8203;8745](DataDog/dd-trace-java#8745) -
[@&#8203;amarziali](https://github.com/amarziali))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am
every weekday" in timezone Australia/Melbourne, Automerge - At any time
(no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Never, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

GitOrigin-RevId: 795f347ae34d056efc1194c2f606cee7bca1beea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants