-
-
Notifications
You must be signed in to change notification settings - Fork 161
Cannot react property 'name' of undefined #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
PCreations
pushed a commit
to PCreations/babel-plugin-react-css-modules
that referenced
this issue
Dec 13, 2016
Oops, duplicate of #7 |
gajus
pushed a commit
that referenced
this issue
Dec 18, 2016
…#13 #14 #17) (#12) * fix: added escape hatch when testing attribute that do not have a name property (#11) * fix: object expression generated on dynamic resolution now use quote to escape properties' name (#14) * fix: getClassName now works as expected when multiple file use runtime resolution * fix: getClassName now works as expected when multiple file use runtime resolution
Fixed in #12. Thank you @PCreations |
gajus
pushed a commit
that referenced
this issue
Dec 19, 2016
* fix: added escape hatch when testing attribute that do not have a name property (#11) * fix: object expression generated on dynamic resolution now use quote to escape properties' name (#14) * fix: getClassName now works as expected when multiple file use runtime resolution * fix: getClassName now works as expected when multiple file use runtime resolution * fix: className attribute is now correctly generated when using runtime resolution (#18)
gajus
pushed a commit
that referenced
this issue
Jan 6, 2017
* Make syntax parser configurable * Make syntax parser configurable * fix: handle multiple file import with dynamic resolution (fixes #7 #11 #13 #14 #17) (#12) * fix: added escape hatch when testing attribute that do not have a name property (#11) * fix: object expression generated on dynamic resolution now use quote to escape properties' name (#14) * fix: getClassName now works as expected when multiple file use runtime resolution * fix: getClassName now works as expected when multiple file use runtime resolution * fix: generate className when using runtime resolution (#18) (#19) * fix: added escape hatch when testing attribute that do not have a name property (#11) * fix: object expression generated on dynamic resolution now use quote to escape properties' name (#14) * fix: getClassName now works as expected when multiple file use runtime resolution * fix: getClassName now works as expected when multiple file use runtime resolution * fix: className attribute is now correctly generated when using runtime resolution (#18) * feat: improve error messages (#21) * Make syntax parser configurable * Merged upstream * Updated the configuration section of the readme file * docs: improve wording * fix: add a missing comma BREAKING CHANGE: If your installation is using CSS, now you need to manually install scss-loader and configure it. https://github.com/gajus/babel-plugin-react-css-modules#configurate-syntax-loaders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
When using spread operator (and maybe other attribute that not might have a
name
property) to passprops
from parent to children, the plugin fails sinceJSXSpreadAttribute
does not have aname
attribute, thus throwing an error when attempting to read thename
property of thisundefined
value.The text was updated successfully, but these errors were encountered: