No className generated when styleName is resolved at runtime #18
Labels
Comments
|
@PCreations Is still still an active issue? |
|
@gajus Yes it is, do you understand it or do you want me to rephrase it ? |
|
@gajus I'm actually trying to solve this one, PR should come today. |
PCreations
added a commit
to PCreations/babel-plugin-react-css-modules
that referenced
this issue
Dec 19, 2016
gajus
pushed a commit
that referenced
this issue
Dec 19, 2016
* fix: added escape hatch when testing attribute that do not have a name property (#11) * fix: object expression generated on dynamic resolution now use quote to escape properties' name (#14) * fix: getClassName now works as expected when multiple file use runtime resolution * fix: getClassName now works as expected when multiple file use runtime resolution * fix: className attribute is now correctly generated when using runtime resolution (#18)
|
Thank you! p.s. I saw your email. To follow up is on my list of things to do. |
gajus
pushed a commit
that referenced
this issue
Jan 6, 2017
* Make syntax parser configurable * Make syntax parser configurable * fix: handle multiple file import with dynamic resolution (fixes #7 #11 #13 #14 #17) (#12) * fix: added escape hatch when testing attribute that do not have a name property (#11) * fix: object expression generated on dynamic resolution now use quote to escape properties' name (#14) * fix: getClassName now works as expected when multiple file use runtime resolution * fix: getClassName now works as expected when multiple file use runtime resolution * fix: generate className when using runtime resolution (#18) (#19) * fix: added escape hatch when testing attribute that do not have a name property (#11) * fix: object expression generated on dynamic resolution now use quote to escape properties' name (#14) * fix: getClassName now works as expected when multiple file use runtime resolution * fix: getClassName now works as expected when multiple file use runtime resolution * fix: className attribute is now correctly generated when using runtime resolution (#18) * feat: improve error messages (#21) * Make syntax parser configurable * Merged upstream * Updated the configuration section of the readme file * docs: improve wording * fix: add a missing comma BREAKING CHANGE: If your installation is using CSS, now you need to manually install scss-loader and configure it. https://github.com/gajus/babel-plugin-react-css-modules#configurate-syntax-loaders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
When using runtime resolution to find the actual
styleName, noclassNameattribute is added to the component, making it unstyled.The text was updated successfully, but these errors were encountered: