Skip to content

file not set up for runtime resolution if runtime resolution is needed in more than one file #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
PCreations opened this issue Dec 16, 2016 · 1 comment
Closed

file not set up for runtime resolution if runtime resolution is needed in more than one file #17

PCreations opened this issue Dec 16, 2016 · 1 comment

Comments

@PCreations
Copy link
Contributor

This is because the following vars are not scoped by file, but to the current build :

index.js (L19-21)

  let styleModuleImportMap;
  let importedHelperIndentifier;
  let styleModuleImportMapIdentifier;

It works for the first file that need runtime resolution but when a second file need runtime resolution, the following condition skips the process :

index.js (L105)

if (!importedHelperIndentifier)
@PCreations PCreations changed the title file not set up for runtime resolution if runtime resolution is needed in more that file not set up for runtime resolution if runtime resolution is needed in more than one file Dec 16, 2016
gajus pushed a commit that referenced this issue Dec 18, 2016
@PCreations @gajus
fix: handle multiple file import with dynamic resolution (fixes #7 #11 …
4ab70fb 
…#13 #14 #17) (#12)

* fix: added escape hatch when testing attribute that do not have a name property (#11)

* fix: object expression generated on dynamic resolution now use quote to escape properties' name (#14)

* fix: getClassName now works as expected when multiple file use runtime resolution

* fix: getClassName now works as expected when multiple file use runtime resolution
@gajus
Copy link
Owner

gajus commented Dec 18, 2016

Fixed in #12. Thank you @PCreations

@gajus gajus closed this as completed Dec 18, 2016
gajus pushed a commit that referenced this issue Jan 6, 2017
@jcdekoning @gajus
Feature: having postcss syntax configurable (#10)
f343ab1 
* Make syntax parser configurable
* Make syntax parser configurable
* fix:  handle multiple file import with dynamic resolution (fixes #7 #11 #13 #14 #17) (#12)
* fix: added escape hatch when testing attribute that do not have a name property (#11)
* fix: object expression generated on dynamic resolution now use quote to escape properties' name (#14)
* fix: getClassName now works as expected when multiple file use runtime resolution
* fix: getClassName now works as expected when multiple file use runtime resolution
* fix: generate className when using runtime resolution (#18) (#19)
* fix: added escape hatch when testing attribute that do not have a name property (#11)
* fix: object expression generated on dynamic resolution now use quote to escape properties' name (#14)
* fix: getClassName now works as expected when multiple file use runtime resolution
* fix: getClassName now works as expected when multiple file use runtime resolution
* fix: className attribute is now correctly generated when using runtime resolution (#18)
* feat: improve error messages (#21)
* Make syntax parser configurable
* Merged upstream
* Updated the configuration section of the readme file
* docs: improve wording
* fix: add a missing comma

BREAKING CHANGE:

If your installation is using CSS, now you need to manually install scss-loader and configure it. https://github.com/gajus/babel-plugin-react-css-modules#configurate-syntax-loaders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gajus @PCreations